From nobody Sat Mar 9 12:11:23 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TsMNL1dY0z5D305 for ; Sat, 9 Mar 2024 12:12:02 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TsMNL19TLz4Znn for ; Sat, 9 Mar 2024 12:12:02 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709986322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ml1AjsAZxp1FdieZ0D3SD30sFN3TC7PE2b7BIhPWqT4=; b=NvxKA2dqQlh6gIw//ezCTw/5KbGJXgzHZKX9kF2Nn8oOigbcTTFfkaOBB8GiWHxcgknszP vnnDRBMf++yJDWrQ7b/tflYKFMfnFtLF7TafimxbMcWzYNw3T8ZUzMbsBLTTGY/mnxwwIa m/yxqyLaPgOFcsG1gLGfuLYf7sghlYqhdwpZR8ebnrBLhMG3S0IAyERS1A0o7YbmHuzgMy zj5ZrufnZ4o1xM/kGZLtV0a8l83wYi5SYitTzGZePFAyar1rEuzmr2HhZEfDZbfgg4761K 9pk/PY4z7Drh0YOxgujd4w0ZphviVQbjLerYpF+qududXQ9lAN/bbYoDCuBUnQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709986322; a=rsa-sha256; cv=none; b=EY2VCRA53uZbW4Pr533wqUoIyVqUBGfCIQLmV/fhjjVIk6isxRwNO0k6QhaLrzA1rY1/ch SrjgnQkGkEvPS9gfvcHg4nnTlJ1PyWTIFImzVPh4zRfrcXc+me8FstUddlSQ42wDaG3fFr V259n+zhwqIDC+UyvoaBiW8Dsfw17240vSZDWB09c1YLFp/pnPRtMqr28drIYDr3ZCs6RU /9jpH6SGsURbBZCHTPO/Mj7ynZjcfbEp83dDxRurlWk65Q3Yd5wcfw1sQe75mPHskMihw7 MOHgwvYXdhcDurNKsshva8WqgMzDXQ3wIcYLM8vy1RYCx/8jyAebWI9YwcrtcA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709986322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ml1AjsAZxp1FdieZ0D3SD30sFN3TC7PE2b7BIhPWqT4=; b=dXTl2uq9g9iLNvLEO4gzgCxgfXbP+abJ3J6S7dBsU/c3RhrKwxR7wJNwH9ru3j0VExskRz l5HHAJxFuH7Sh+hw66EUpxIBADnWxlVusaEKDQ0waEOG+7WHIwFcfpIMP+SBUe/ewHL/3Q F/wOeHaUVYp9uQslOgtZ0CDu8gdqC1IdCz6tXoH9LrUMIAfjITEfd6xwLB/JtkIa/MCYH2 Z4CDkHB6tU9dbrbkt/ZvUCy5mgI5q6tNsqtB521b+6HamMHGfLXb2wLAewBMhzCy4OUKO7 AJYojfvduSbIREaNcGZ9R8rmO8W2OfeAo29LR//5tDarFn6oFKTG8l5H09wsAA== Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TsMNL0gJhz13TQ for ; Sat, 9 Mar 2024 12:12:02 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5683247fd0fso1861489a12.3 for ; Sat, 09 Mar 2024 04:12:02 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXUsuy2vpCRrHQ4EObgoIJtBtJ/wVXFzXSqmnLtrVXFyguUiUDHMOKF0zYcQFXvmSa1VRxWHJLHflqPcVULT5+LKtrWM3SgKErMiQ7EWAXakr8= X-Gm-Message-State: AOJu0YyiVV2F0ifIAL/xH7NvUVm87zM5VjuSYOFdvdYR0iQfP2oPwSIm 2sLEOHFMyfYbOazAprRlCG48lXFwtOx5huGXW/FxcTunQl9h/fDXOcgI2EjksKFMcMqcIL/PDuw XbIDNyxB7hvaGko0FLsqSeg9eZYrSfAfHBlHTIA== X-Google-Smtp-Source: AGHT+IFsVt8Zpgrx0wHUIbfSw0Ga8AF3gHDvHhDcMt+QFdSupRqp9sdmsgodcp2adHvp7m3D2ctjVqqxQ55AUJV12Io= X-Received: by 2002:a17:906:b08b:b0:a45:c18e:9679 with SMTP id x11-20020a170906b08b00b00a45c18e9679mr934122ejy.6.1709986320594; Sat, 09 Mar 2024 04:12:00 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202402211520.41LFK8mS022399@gitrepo.freebsd.org> <9ea613e41885bc4b8cab826a1d5508da@mail.infomaniak.com> In-Reply-To: <9ea613e41885bc4b8cab826a1d5508da@mail.infomaniak.com> From: Po-Chuan Hsieh Date: Sat, 9 Mar 2024 20:11:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 450aafcba559 - main - textproc/tinyxml2: Update to 10.0.0 To: Daniel Engberg Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000035dbfe06133937cb" --00000000000035dbfe06133937cb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 23, 2024 at 5:23=E2=80=AFAM Daniel Engberg < daniel.engberg.lists@pyret.net> wrote: > On 2024-02-21T16:20:08.000+01:00, Po-Chuan Hsieh > wrote: > > The branch main has been updated by sunpoet: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D450aafcba559f95c94c5f195= d83b5fe4fdc3748a > > commit 450aafcba559f95c94c5f195d83b5fe4fdc3748a > Author: Po-Chuan Hsieh > AuthorDate: 2024-02-21 14:29:27 +0000 > Commit: Po-Chuan Hsieh > CommitDate: 2024-02-21 15:06:47 +0000 > > textproc/tinyxml2: Update to 10.0.0 > > - Convert to meson > - Fix 0c022f0fc854184d95ff3303049a063a39b1f551 > - Bump PORTREVISION for package change > - Bump PORTREVISION of dependent ports for shlib change > - Remove duplicate PORTREVISION from math/linbox > > Changes: https://github.com/leethomason/tinyxml2/releases > https://github.com/leethomason/tinyxml2/commits/maste= r > --- > > Hi, > > Please explain what you fixed as this change makes consumers utilizing > CMake to find (lib)tinyxml2 now requiring patching when they worked fine > before your change? > > Your patch for net/ecal is not a fix but a workaround for something that > broke by this commit. > > Here's a build log of said port and the PR related. > > https://pdr2.bofh.network/data/132-diizzy/2024-01-01_11h58m45s/logs/ecal-= 5.12.1_3.log > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277227 > > Best regards, > Daniel > Hello, Obviously you did not handle the dependent ports which encounter shlib change. Enforce port A to use cmake because port B uses cmake. This behavior is toxic. It works like a virus. Regarding net/ecal, please explicitly point out what is the broken in net/ecal. If you mean something like "(ecal-5.12.1_3) /wrkdirs/usr/ports/net/ecal/work/stage//usr/local/bin/ecal_mon_gui-5.12.1 - required shared library libCustomQt.so not found", I see nothing related with tinyxml2's cmake script. Not to mention that I see the same message when tinyxml2 is built with cmake. The cmake problem is misleading information. Regards, sunpoet --00000000000035dbfe06133937cb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Feb 23, 2024 at 5:23=E2=80=AFAM D= aniel Engberg <daniel.engberg.lists@pyret.net> wrote:
O= n 2024-02-21T16:20:08.000+01:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org>= wrote:
Th=
e branch main has been updated by sunpoet:


commit 450aafcba559f95c94c5f195d83b5f=
e4fdc3748a
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
=

AuthorDate: 2024-02-21 14:29:27 +0000
Commit:     Po-Chu=
an Hsieh <sunpo=
et@FreeBSD.org>
CommitDate: 2024-02-21 15:06:47 +0000<=
br>

    textproc/tinyxml2: Update to 10.0.0
    
    - Convert to meson
    - Fix 0=
c022f0fc854184d95ff3303049a063a39b1f551
    - Bump PORTREVISI=
ON for package change
    - Bump PORTREVISION of dependent po=
rts for shlib change
    - Remove duplicate PORTREVISION from=
 math/linbox
    
---<=
/div>
Hi,

Please = explain what you fixed as this change makes consumers utilizing CMake to fi= nd (lib)tinyxml2 now requiring patching when they worked fine before your c= hange?

Your patch for net/ecal is not a fix bu= t a workaround for something that broke by this commit.

Hello,

Obviously you did not handle the dependent ports which encounter=C2=A0shli= b change.

Enforce port A to use cmake because port= =C2=A0B uses cmake.
This behavior is toxic. It works like a virus= .

Regarding net/ecal, please explicitly point out = what is the broken in=C2=A0net/ecal.
If you mean something like &= quot;(ecal-5.12.1_3) /wrkdirs/usr/ports/net/ecal/work/stage//usr/local/bin/= ecal_mon_gui-5.12.1 - required shared library libCustomQt.so not found"= ;, I see nothing related with tinyxml2's cmake script.
Not to= mention that I see the same message when tinyxml2 is built with cmake.
=

The cmake problem is misleading information.
<= /div>

Regards,
sunpoet
--00000000000035dbfe06133937cb--