From nobody Fri Apr 8 00:03:15 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F0F0E1A86DDA; Fri, 8 Apr 2022 00:03:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KZJNz5ppwz4kZZ; Fri, 8 Apr 2022 00:03:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649376195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r/GtmAP1HH//G8G55gRpJF2EfgPYIssu5I3OCJ+f3a4=; b=VmTcmvPz2eZmWP+YNN3i6ZuDrKBbvYVQMFex8l/IRatw7Q742EFgmB8Vevi1H3Z+tizio7 c0Gi7Vmt93+XZQtgCQsYu9+DTdqLj/Bf4TekLOpNc8cF+iqK1w6xnkdDw0DZX8K3ifAr0e CUgUDoXIDbSS3FibQtb3nJqv1rdjoGu/j3bV0yuOJtW8eqfEJnUoRTNTOpSXO/OXB6xyXG Irfm6oz0/CQhYxM76JOaf7dmKyPk9FMEtSjXs3EKJnKnA3wpbO/O0QW29bzZ4A6SPT74EL N843HAXgDhLkKeDG9/LxQglmQkyuIEJDY/PYwLOjoWoLKRmQTBDvX3FGL0zdJg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9DFF41A497; Fri, 8 Apr 2022 00:03:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23803FDg086122; Fri, 8 Apr 2022 00:03:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23803FpQ086121; Fri, 8 Apr 2022 00:03:15 GMT (envelope-from git) Date: Fri, 8 Apr 2022 00:03:15 GMT Message-Id: <202204080003.23803FpQ086121@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: b08a56ad4608 - main - mxgbe: Remove a dummy variable used to force a register read. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b08a56ad4608586ce457838655db7e59a126e08d Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649376195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r/GtmAP1HH//G8G55gRpJF2EfgPYIssu5I3OCJ+f3a4=; b=cde7gs07BXE3JJ+0nDBVIUIMx5k+D6hnqJeRrkj+FpWlZNTnVZ52lfsVDu+bxHc5k79Bo4 Rf86IOnpTJz/gWlprxwmUq23AXpMvG1CKfMBIuKYcjARowVnrLhJfe7xVNo+Ys8+EStzC1 YrYAO0ApdvqA6wRrieZYhDuN/xuUXEWWE0BL/uqk0sRVRCjA2VIImPDdPrlOzyIq7hpvrg 2sTwJtLOsxC1A860zQyzcM6rU1oDk4rro+E3Xwf8x18YpmCbCY9QxTQQI6zd3QXQeMNpf2 +fAsHJlVSnBvtX4wtsgvI3GORXUhKNS3n9dWA8H9afeZMAiADuj4uvFSAo/uow== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649376195; a=rsa-sha256; cv=none; b=nm7P0Y8LozUeF5HNz87OYWtVlmmBAszWg2pt6hX2Iq6BOYoS60QlQcwRdtXRLK2eNs4XgG /74dI3ltokW4zEijvmOgs0FGdPy4eD3rc7bInA/vMdMuNEgUn97QOTJBFzKxC3e3ENIkHF uWEB2rbGAZ98fzAy8Tyr2gPzXfFpdSiMvUVWiwATyV8ty0hrHbrmsZFbq0V0yQUo+FAJnI /Za53roMCSN2XWDyBosGQTopWywLY4tyYysONaOf4YlQa5ZNGF2wMM6s+o9Nwum3G9Ct0b /EcQWg6LGkK2SLX1+GgUNHOHzO8h8q4J6fRSOgNriOin25ny6t22TcijwUa9hw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=b08a56ad4608586ce457838655db7e59a126e08d commit b08a56ad4608586ce457838655db7e59a126e08d Author: John Baldwin AuthorDate: 2022-04-08 00:01:26 +0000 Commit: John Baldwin CommitDate: 2022-04-08 00:01:26 +0000 mxgbe: Remove a dummy variable used to force a register read. Keep the register read by casting the result of the pointer indirect to void. --- sys/dev/mxge/if_mxge.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/mxge/if_mxge.c b/sys/dev/mxge/if_mxge.c index aea6459e41b6..2c175ed6fdc7 100644 --- a/sys/dev/mxge/if_mxge.c +++ b/sys/dev/mxge/if_mxge.c @@ -686,7 +686,6 @@ mxge_load_firmware_helper(mxge_softc_t *sc, uint32_t *limit) unsigned hdr_offset; int status; unsigned int i; - char dummy; size_t fw_len; fw = firmware_get(sc->fw_name); @@ -743,7 +742,7 @@ mxge_load_firmware_helper(mxge_softc_t *sc, uint32_t *limit) inflate_buffer + i, min(256U, (unsigned)(fw_len - i))); wmb(); - dummy = *sc->sram; + (void)*sc->sram; wmb(); }