Date: Fri, 8 Apr 2022 00:03:15 GMT From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: b08a56ad4608 - main - mxgbe: Remove a dummy variable used to force a register read. Message-ID: <202204080003.23803FpQ086121@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=b08a56ad4608586ce457838655db7e59a126e08d commit b08a56ad4608586ce457838655db7e59a126e08d Author: John Baldwin <jhb@FreeBSD.org> AuthorDate: 2022-04-08 00:01:26 +0000 Commit: John Baldwin <jhb@FreeBSD.org> CommitDate: 2022-04-08 00:01:26 +0000 mxgbe: Remove a dummy variable used to force a register read. Keep the register read by casting the result of the pointer indirect to void. --- sys/dev/mxge/if_mxge.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/mxge/if_mxge.c b/sys/dev/mxge/if_mxge.c index aea6459e41b6..2c175ed6fdc7 100644 --- a/sys/dev/mxge/if_mxge.c +++ b/sys/dev/mxge/if_mxge.c @@ -686,7 +686,6 @@ mxge_load_firmware_helper(mxge_softc_t *sc, uint32_t *limit) unsigned hdr_offset; int status; unsigned int i; - char dummy; size_t fw_len; fw = firmware_get(sc->fw_name); @@ -743,7 +742,7 @@ mxge_load_firmware_helper(mxge_softc_t *sc, uint32_t *limit) inflate_buffer + i, min(256U, (unsigned)(fw_len - i))); wmb(); - dummy = *sc->sram; + (void)*sc->sram; wmb(); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202204080003.23803FpQ086121>