From owner-freebsd-scsi@FreeBSD.ORG Sun Sep 21 06:31:08 2003 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE34316A4B3; Sun, 21 Sep 2003 06:31:08 -0700 (PDT) Received: from esper.modulus.org (c198-142-207-94.rivrw5.nsw.optusnet.com.au [198.142.207.94]) by mx1.FreeBSD.org (Postfix) with ESMTP id 402E743FE1; Sun, 21 Sep 2003 06:31:03 -0700 (PDT) (envelope-from als@kanji.com.au) Received: from kanji.com.au (unknown [172.16.1.8]) by esper.modulus.org (Postfix) with ESMTP id CF9FD114AC; Sun, 21 Sep 2003 23:31:39 +1000 (EST) Message-ID: <3F6DA7E3.5040709@kanji.com.au> Date: Sun, 21 Sep 2003 23:30:11 +1000 From: Andrew Snow User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030507 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Clive Lin References: <3F64E50E.2040608@kanji.com.au> <20030921130539.GA64930@fatpipi.cirx.org> In-Reply-To: <20030921130539.GA64930@fatpipi.cirx.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-scsi@freebsd.org Subject: Re: ibm x345 w/ serveraid-5i + freebsd ips driver dramas X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2003 13:31:08 -0000 > sys/dev/ips/ips_disk.c > - dsc->ipsd_disk.d_mediasize = totalsectors * IPS_BLKSIZE; > + dsc->ipsd_disk.d_mediasize = (long long) totalsectors * IPS_BLKSIZE; Argh :-) I stared at those lines for so long, and that solution never occured to me. I suggest that (off_t) would be the correct cast for all platforms. Thank you, and I wonder if this patch can be confirmed by scottl and applied to the next release of FreeBSD 5? - Andrew