From owner-cvs-src@FreeBSD.ORG Fri Aug 4 15:44:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADEA416A4E6 for ; Fri, 4 Aug 2006 15:44:15 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id D65EC43D67 for ; Fri, 4 Aug 2006 15:44:12 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 12579 invoked from network); 4 Aug 2006 15:35:21 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 4 Aug 2006 15:35:21 -0000 Message-ID: <44D36B4B.4050605@freebsd.org> Date: Fri, 04 Aug 2006 17:44:11 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) MIME-Version: 1.0 To: Prafulla Deuskar References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> <20060804143825.GA8797@hub.freebsd.org> In-Reply-To: <20060804143825.GA8797@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Gleb Smirnoff , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 15:44:15 -0000 Prafulla Deuskar wrote: > Gleb Smirnoff [glebius@FreeBSD.org] wrote: >> Prafulla, >> >> On Thu, Aug 03, 2006 at 07:05:05PM +0000, Prafulla Deuskar wrote: >> P> pdeuskar 2006-08-03 19:05:05 UTC >> P> >> P> FreeBSD src repository >> P> >> P> Modified files: >> P> sys/dev/em if_em.c if_em.h >> P> Log: >> P> Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. >> P> This makes it easier for us to get the changes into -current and to -stable quickly. >> >> Can you please confirm that this was a mechanical substitution like this: >> >> s/sc/adapter/g >> s/em_softc/adapter/g >> >> and no more additional changes? If this is true, then I hope that we >> (FreeBSD and Intel) have finally came to a common codebase. This is good. :) >> I can stand the long unusual name for driver softc with no problems. >> >> I'm only a bit disappointed by the fact, that I haven't received a single >> email about these plans. You were in the void for a long time, and >> then began your work with a commit, w/o informing people who were >> maintaining driver while the vendor maintanance was on a hiatus. >> > > Yes - it was a mechanical substitution. According to jb@freebsd.org at least one non-mechanical change slipped in breaking his Sun4v box. AFAIR some fix in/with bus_dmamap_unload() was reverted. -- Andre