From owner-freebsd-standards Wed Feb 6 0:59:34 2002
Delivered-To: freebsd-standards@freebsd.org
Received: from descent.robbins.dropbear.id.au (158.b.006.mel.iprimus.net.au [210.50.45.158])
by hub.freebsd.org (Postfix) with ESMTP id D64BC37B436
for <freebsd-standards@FreeBSD.ORG>; Wed, 6 Feb 2002 00:59:29 -0800 (PST)
Received: (from tim@localhost)
by descent.robbins.dropbear.id.au (8.11.6/8.11.6) id g168uUJ37860;
Wed, 6 Feb 2002 19:56:30 +1100 (EST)
(envelope-from tim)
Date: Wed, 6 Feb 2002 19:56:29 +1100
From: "Tim J. Robbins" <tim@robbins.dropbear.id.au>
To: Chuck Rouillard <chuckr@opus.sandiegoca.ncr.com>
Cc: freebsd-standards@FreeBSD.ORG
Subject: Re: pathchk - review
Message-ID: <20020206195629.A37672@descent.robbins.dropbear.id.au>
References: <20020129210829.GC50337@madman.nectar.cc> <20020205232519.N7805-101000@opus.sandiegoca.ncr.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20020205232519.N7805-101000@opus.sandiegoca.ncr.com>; from chuckr@opus.sandiegoca.ncr.com on Tue, Feb 05, 2002 at 11:54:26PM -0800
Sender: owner-freebsd-standards@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-standards.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-standards>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-standards>
X-Loop: FreeBSD.ORG
On Tue, Feb 05, 2002 at 11:54:26PM -0800, Chuck Rouillard wrote:
> A revised `pathchk' is being submitted for review.
In pathchk.1, it'd be good to change
.Pp
.Nm pathchk
exits 0 on success, 1 if an error occurred.
to:
.Sh DIAGNOSTICS
.Ex -std
There is a typo here, should be _POSIX_NAME_MAX:
The
.Ar pathname
contains a path component longer than the maximum _POXIX_NAME_MAX.
mdoc(7) recommends the SEE ALSO section be alphabetised.
In pathchk.c, I think it'd be better to use the warn and err family of
functions instead of fprintf and perror ("Use err(3) or warn(3), do not roll
your own.")
The \n should probably be removed here, since it is later added by fprintf
in usage():
const char *pathchkhelp = "usage: pathchk [-p] path ...\n";
The lines that say *path = NULL; should be *path = '\0';
Other than those few nits, it looks fine.
Tim
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-standards" in the body of the message