From owner-dev-commits-src-main@freebsd.org Mon Feb 1 10:48:22 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1EEAE4FA106 for ; Mon, 1 Feb 2021 10:48:22 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic302-21.consmr.mail.gq1.yahoo.com (sonic302-21.consmr.mail.gq1.yahoo.com [98.137.68.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DTl6D6PQnz54h6 for ; Mon, 1 Feb 2021 10:48:20 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1612176499; bh=X1VJDGxsp874mh5ozSLnl9ZTDbm37WiJr1MbLWmRJPT=; h=From:Subject:Date:To:From:Subject:Reply-To; b=WPgvdrUWzdkKpeEuMp5KJXGgQNudYTmkSsZmHsSb6k8qPMFwE60gm+ICehmlboWXSMvPI2+dsknO+Ok0ZvM7bFh8w0nbrFnxVrvIqGOeIH2AemgEszN2Jfb3+/dN77BdWp6cYVYSuZsIcLSCGp8sQ0H5ZhmG9Vnwjm31UUClzOTc6rx9K8FxlISh47tL10w58fohTZSOvdoyhw6XyyLuxygSClwgz0KS+ai9LSIZtzTanFJVcgWUwCBmXhsgtStP4a/d9jYzr2FU3umQqnHpz+A1BZnWRB+I4LYTHNIlz3Zw7jijuY2bpN+1trIFRQEeVVXcce8XBqqKr9xHfR4tpg== X-YMail-OSG: TNt_EqMVM1n3DzpYiW9xpcVVFvVxOAgc0Wpoccqg3sFpU_FRXThES.r7HeyQgwA VfY6YmcvLu6WMNjGemR7m.azcH_vbKQhYjv9Raj.D0MSK.rsNj3rv9MdXSIn8C_K07TBJ4JS1Sg6 ETinqxhLLmSrDXYLU2QGmGNM.aC9I4bGns8PMw7cEmPnWmXSb4beaNb7lJ6XkhCogf6DEYLAmkjD FujAcHoXXv8rJOPxW6zzNCKcpeXoES1uxg.rYEUmHuv0Rjfxb17e1.PysBNl4EqJU9KEItSiaYZ1 TA_A81YIeN36IjGWKz7lOMGn96lJtu5fgLGg2eVi.3MGbiGtxk.qOFKB.ASMSYHYbTtOo4yMpvP9 pxcfiy4RJ49eZYLowKOrKpEIDB3KrSsbRgEy2Rua1ebu0.vmUtOhxcGTKehd5TP8cXBIHCRhLaZz iWDIapNjoVUY5JlfqBLhJAMXdsn.hSLf9n.YGUdCijpOoOlFMkDLUbZNFSygcW9u0qik6QMRrJA3 ucNnMEd0hJ9VfHXb7Gv9Z.1QvZMqCBuZYHd1KT5_iEwobfgoIaI.qr1CLj.SGEdw8eC6PEQAV4jw Db6sBbIs.3OJS3wO45o6XF51gC4jgSo1sqnQwUHeMaWyfFEqJmtZ1O2lGxsuLXz0JSCBzkiweD7d ix60BsWsilSsfaCn.4aLHSglmnA52RK4Hpc.9tvDoqhnW6LiZO_hWCkYuRgPZcsY9yheM5kMSmWp Ma9pV1ZQ.IIIYvtHqPU7tHFk8ung2asK8qqR976umQLN5szSxXwizGYEQt6tFOb46zbXmEth5mMZ aM_ve14Ct65i2JyUKGkWNe9hnRk7UCOEACLD_S2UvPquZAc7k.5vO7A8QmqbWlvu1isDSCfBQdaR 2MqQuasbYHUGqheuSjWb712lXmyiZFX4HENqkj0IPXsqozxKnBuek7FwolQd9pANc8zXafecWTEf a8mkw.b9mzDKgeu.BFeQR8.jI242YRiU1BzzMp3FV_kZZLxvRXUURP2PYRZ3jqK4eRYVtc1fuNXc nv8YpbwDOdX.kopDFDVWG1aODxQX61Mf.J1FSS4e0.ST24W_VUp1.of1_xULCRTMs.yBkrg5CnVA .Y4g2_ToOGYR5U_jFfUK2pdcMBDrw8iec4ILKOdY1yaH2jzYox5ADQhuWPkQNtSBIWlZ0GZ2_D83 rxkqhqHhuiXByRiLlv2SzNejtXwEHfgZILmK_8ei_HGgdEinOEr0k1N7eSP2pLj3HwaLnZh3lrZH cFM6aPdyVNuvU.Jjp1GeTRmXIL9VFDrsO4Fg_vfzASFelcLmLVMG06MIRmLfX1ZAZ9BhDJwimt_G V7bQCGJKwe28L33_FG1aqRdz2xj7ZHvPXJDfvugsHFc8DUkh58FjI7XmQ7wEhWisz4twnBM4ht1x NcRUSVkWmPOGAmv7yjxFO4QLb7X_fngnp1Bf106UmOCNfYndc2iTp6se5kW58oe_6dgE8Yf02Zy5 pCfXqkrPspTBU83krVIvypgsGUUskhXwMacFCZiLAlPEcK_9jX0NyDkURN_CSyzWW87a6t8E8VcF WwboO1AcjgcIKAVNQ3.hbkuq.R_KtP3xbOE4mt_vZfBZEmrysurGP3d.N0XlU33SWgXv7fSsHIju AcOIFYQ.h3Tyu1yljNk3hFnXndaezScba7DF0G2swa5_ShfaeY3ZeISMo6HdJx1tHMVPqCCmLeVN OXTqV7A1d5wjwG5TF6IM7n2cCz16S9walTZ8dk2Eae4AZanKQxuv1xJUnqoPSKeNp3gtypzTcmwr 9qZkkz.ZZWFTyvvARer33OcrHgz.AAKpnJcTAI5AKpH0ktKHFesERgdEwXLkcwSXViLCM.h.Y5QQ 5JQoSNgUWXrz.YFlofPf3xov5804DipMSgrJkI0exeZbF6z3SFDnTxu8GXjICALh4cQL6sa4Pgee 0lw5GC1p6PV18ZrVmB5InX1_302kq_hkAw.OPxotyJ_OK_UYLkqhAsHqa7kxT9Qdu_DPwUzdAavq mAk.A1SljEm2jpK176Q.3toReaQ.f_1DUXMzn_djXWPVxioaJEV9WLNfIessl7LmkngYhE.qpmgp _ifrruPdwkLzqJ5amLOhH_0_92PRJZFZL7kZXBS0zTYKxusvnitnKiY2Gsp9eVZXw1ke_4dKJSl0 95dvF4.JNyCZdzoT7xGjleCGBopOoEP3qVKResL1S5pOWUCTXwkeCby1RpaxbzTfb9lRBoAPekod 3lzWz4FJsSSbxOpyOr14lSIuTPA.64bUmYQNLrwtwiNcmxqO66S2FZCRG3krEObT3o7Vb6dJkRia c7YbT9JBPBr8yZNvISRQ6qF6eVi48Alboz7qD0qss64uKdjGCv7lLy6we6nxuFG7uEzWSIV5LoNu yyaTPAb9Pev5RAWXX15sszN1_S.tvLZSZGhvWLBbcTf5vrmh.zEqsOMRqNOHtcWGNrxE4hm7Bo0N D3bV4NAjWEdViWvMd5Fp9sDKKsVgedJtgRPmUgQ-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.gq1.yahoo.com with HTTP; Mon, 1 Feb 2021 10:48:19 +0000 Received: by smtp420.mail.ne1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 3734aa63e7ce1d1fd54539f7437964f8; Mon, 01 Feb 2021 10:48:14 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: git: 7fa2f2a62f04 - main - Rename NO_WERROR -> MK_WERROR=no Message-Id: <9110AE5B-4BC0-4BF0-A33E-5E1C78224B9E@yahoo.com> Date: Mon, 1 Feb 2021 02:48:12 -0800 To: "arichardson@freebsd.org" , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3654.40.0.2.32) References: <9110AE5B-4BC0-4BF0-A33E-5E1C78224B9E.ref@yahoo.com> X-Rspamd-Queue-Id: 4DTl6D6PQnz54h6 X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[98.137.68.147:from]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_ZRD(0.00)[98.137.68.147:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.68.147:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.68.147:from]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-main] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2021 10:48:22 -0000 > On Sun, 31 Jan 2021 at 19:12, Antoine Brodin = wrote: > > > > On Sun, Jan 10, 2021 at 12:12 PM T=C4=B3l Coosemans wrote: > > > > > > On Thu, 7 Jan 2021 11:05:55 GMT Alex Richardson > > > wrote: . . . > > > NO_WERROR is also used by some ports [1] (which have to build = against > > > multiple version of FreeBSD) and this turns it into an error. Can = you > > > remove this change or turn it into a warning maybe? Changes to = share/mk > > > should always go through a ports exp-run IMHO. > > > > Ping Alex Richardson? > > > > Antoine (with hat: portmgr) >=20 > Hi Antoine, >=20 > I submitted https://reviews.freebsd.org/D28084 to change this error to = a .info. > However, T=C4=B3l said that there weren't many affected ports so this > change should not be needed. > I can commit this workaround, but if I do this just postpones the > problem to when we want to remove the workaround (and might mean it > will never be removed). Maybe those ports should just be built with a > lower WARNS? If one mistakenly leaves NO_WERROR in someplace like, say, /etc/make.conf and so the errors occur during something that uses make in a way that happens to do the check, such as possibly in etcupdate's use of make, is the overall behavior of the overall operation known to always avoid doing anything nasty? The same sort of question applies to a warning or such but more is the same as before in that case and so problems seem possibly less likely. As far as I can tell, NO_WERROR becoming depreciated had no transition period of notifications about progressing past 12 to 13 or later. Existing procedures may just suddenly stop working as intended where NO_WERROR was in use for whatever reason. (I had an example of missing a NO_WERROR removal and having to recover from odd behavior that I expect was a consequence, although I've not proven such. Having found and removed the NO_WERROR, I've had no more such odd behaviors, which is at least suggestive.) =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)