Date: Sat, 30 Jan 2016 21:25:21 +0300 From: Slawa Olhovchenkov <slw@zxy.spb.ru> To: mokhi <mokhi64@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: thread-unsafety problems as spl*() ones are NOP Message-ID: <20160130182521.GM88527@zxy.spb.ru> In-Reply-To: <CAByVWPUz2nMuWncsv648BGHReBvtP3r1afAz0LC%2BWD5tikdYDA@mail.gmail.com> References: <CAByVWPWuqdtZ-5p2%2BvGf4v%2BPjjCBkiTQSsZQ06vk-f=bx_TQrQ@mail.gmail.com> <CAByVWPWQJ1wP95S59SiWWBa0k9j2%2Bu1az-D04_V1voo99CxqCw@mail.gmail.com> <20160130180256.GT37895@zxy.spb.ru> <CAByVWPUz2nMuWncsv648BGHReBvtP3r1afAz0LC%2BWD5tikdYDA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jan 30, 2016 at 09:42:13PM +0330, mokhi wrote: > i currently only wanna do patch on kbd.c (because i'm sure there is a > thread-unsafety) > and i don't want to add anything to spltty() nor splx(), i just wanna > add things under where they've been used. > isn't problem with using mutex/spin/lock/unlock etc there? yes. currenly spltty act as mutex_lock(&spltty_mutex), like global lock for all used files. this is also inter-files lock, not only lock inside only kbd.c. you need patch all files. all using spltty need to remove simultaneously.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160130182521.GM88527>