From owner-freebsd-bugs@FreeBSD.ORG  Fri Dec 19 01:50:20 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5364A16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 19 Dec 2003 01:50:20 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5A62243D54
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 19 Dec 2003 01:50:19 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	hBJ9oJFR099025	for <freebsd-bugs@freefall.freebsd.org>;
	Fri, 19 Dec 2003 01:50:19 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id hBJ9oJlt099024;
	Fri, 19 Dec 2003 01:50:19 -0800 (PST)
	(envelope-from gnats)
Date: Fri, 19 Dec 2003 01:50:19 -0800 (PST)
Message-Id: <200312190950.hBJ9oJlt099024@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Gleb Smirnoff <glebius@cell.sick.ru>
Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays
	in it forever
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Gleb Smirnoff <glebius@cell.sick.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Dec 2003 09:50:20 -0000

The following reply was made to PR kern/47920; it has been noted by GNATS.

From: Gleb Smirnoff <glebius@cell.sick.ru>
To: Yar Tikhiy <yar@FreeBSD.ORG>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever
Date: Fri, 19 Dec 2003 12:49:55 +0300

 On Thu, Dec 18, 2003 at 08:22:04PM +0300, Yar Tikhiy wrote:
 Y> Thanks!  By the way, don't you think that the default value for the
 Y> sysctl controlling pppoe mode should be -1?  I've just read this PR
 Y> once more and realized that the current default of 0 is *really dangerous*
 Y> because a spurious non-standard PPPoE frame can plague an entire network!
 
 You are absolutely right. This is a real DoS condition. I have mentioned this
 in freebsd-net, but nobody payed attention. As well as nobody payed attention
 to PR itself. May be it was ignored because of its type: "change-request", not
 "sw-bug" (originator's fault).
 
 When I submitted the patch, I wanted it to be commited as soon as possible,
 so I didn't change default behavior. AFAIK, patches that do change default
 behavior are applied more slowly. Set me right, if I mistake.
 
 So, I absolutely agree that default value should be -1. :)
 
 -- 
 Totus tuus, Glebius.
 GLEBIUS-RIPN GLEB-RIPE