From owner-svn-src-head@FreeBSD.ORG Wed Nov 20 08:27:18 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2A02F3F9; Wed, 20 Nov 2013 08:27:18 +0000 (UTC) Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl [195.190.28.81]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DE2F9262F; Wed, 20 Nov 2013 08:27:17 +0000 (UTC) Received: from smtp.greenhost.nl ([213.108.104.138]) by smarthost1.greenhost.nl with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1Vj37y-0002pM-BR; Wed, 20 Nov 2013 09:27:14 +0100 Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes To: "George V. Neville-Neil" , "Luigi Rizzo" Subject: Re: svn commit: r258328 - head/sys/net References: <201311182258.rAIMwEFd048783@svn.freebsd.org> <20131119210821.GA13961@onelab2.iet.unipi.it> Date: Wed, 20 Nov 2013 09:27:12 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Ronald Klop" Message-ID: In-Reply-To: <20131119210821.GA13961@onelab2.iet.unipi.it> User-Agent: Opera Mail/12.16 (Win32) X-Authenticated-As-Hash: 5a5bc696c05b24d66fef48d694aeed0652e57d03 X-Virus-Scanned: by clamav at smarthost1.samage.net X-Spam-Level: / X-Spam-Score: -0.0 X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 X-Scan-Signature: e462de357cb394d64966911c06262bc8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2013 08:27:18 -0000 On Tue, 19 Nov 2013 22:08:21 +0100, Luigi Rizzo wrote: > On Mon, Nov 18, 2013 at 10:58:14PM +0000, George V. Neville-Neil wrote: >> Author: gnn >> Date: Mon Nov 18 22:58:14 2013 >> New Revision: 258328 >> URL: http://svnweb.freebsd.org/changeset/base/258328 >> >> Log: >> Allow ethernet drivers to pass in packets connected via the nextpkt >> pointer. >> Handling packets in this way allows drivers to amortize work during >> packet reception. > > yes. > > This is only a first step and eventually we should pass the entire > batch to the netisr handler to further reduce overhead. > > Some of the followup emails suggested to change the argument from > struct mbuf * to something else. > I do think we should change it, but what we need is a struct with > head and tail pointers _and_ a counter, because sometimes the code > downstream may have to append the mbuf/batch to a queue, > and these extra fields would save iterating through the chain. > > Related to this: at some point we should also address batching > in the transmit path, and for that we will eventually need to > introduce a 'more packets to come' flag to the API/mbuf so that > intermediate functions in the path will build batches before passing > them down. > > cheers > luigi The Apache webserver works like this also. It has a 'bucket'-list which chains all data of a request and can also contain flush-commands in between. Probably nice to look what they do and in what ways. Ronald.