From owner-cvs-all@FreeBSD.ORG Fri May 30 21:52:09 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0990F37B401; Fri, 30 May 2003 21:52:09 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA1E143F3F; Fri, 30 May 2003 21:52:07 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.8/8.12.3) with ESMTP id h4V4q6kA080818; Fri, 30 May 2003 22:52:07 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 30 May 2003 22:51:56 -0600 (MDT) Message-Id: <20030530.225156.71089616.imp@bsdimp.com> To: jhb@FreeBSD.org From: "M. Warner Losh" In-Reply-To: References: <20030530200512.GE60607@sunbay.com> X-Mailer: Mew version 2.1 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: ru@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/security/mac_mls mac_mls.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 May 2003 04:52:09 -0000 In message: John Baldwin writes: : This is just a symptom of the problem that module Makefiles duplicate : metadata in sys/conf/files (namely the list of files in a given module). : The modules Makefile's should somehow be changed to get their list of : files (as well as nowerror settings) from the sys/conf/files. Essentially, : you almost want to build the acpi module like so: : : % cd modules/acpi : % cat conf : # ACPI module configuration : : device acpi : % config conf : ... generate makefiles, etc. ... : % make : ... compiles acpi.ko ... : : And avoid having to duplicate the metadata about what belongs in a : module. Basically, you build a kernel that doesn't include standard : and doesn't require a CPU keyword. Only if I don't have to config every module that I'm going to compile with the kernel. How would you deal with, say, the ed device which needs to have isa, pccard, cbus, and pci attachments? device 'ed' would be insufficient without knowledge of these attachments. Warner