From owner-freebsd-stable@FreeBSD.ORG Sun Jun 15 21:29:09 2003 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C044737B401 for ; Sun, 15 Jun 2003 21:29:09 -0700 (PDT) Received: from pop015.verizon.net (pop015pub.verizon.net [206.46.170.172]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA02143FB1 for ; Sun, 15 Jun 2003 21:29:08 -0700 (PDT) (envelope-from cswiger@mac.com) Received: from mac.com ([141.149.47.46]) by pop015.verizon.net (InterMail vM.5.01.05.33 201-253-122-126-133-20030313) with ESMTP id <20030616042907.ARR20810.pop015.verizon.net@mac.com> for ; Sun, 15 Jun 2003 23:29:07 -0500 Message-ID: <3EED4790.6060302@mac.com> Date: Mon, 16 Jun 2003 00:29:04 -0400 From: Chuck Swiger Organization: The Courts of Chaos User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030529 X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-stable@freebsd.org References: <200306152041.h5FKfoQo002747@apollo.backplane.com> <3EECF1EE.7000201@mac.com> <200306152351.h5FNptsC011948@apollo.backplane.com> In-Reply-To: <200306152351.h5FNptsC011948@apollo.backplane.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Authentication-Info: Submitted using SMTP AUTH at pop015.verizon.net from [141.149.47.46] at Sun, 15 Jun 2003 23:29:07 -0500 Subject: Re: dvd+rw-tools ported to FreeBSD (Sony 500A DVD[+/-]R[W] support) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jun 2003 04:29:10 -0000 Matthew Dillon wrote: [ ... ] > Looks good. Wow, you came up with that pretty fast! There was an > issue w/ your archive, the Makefile needs to use a tab instead of > spaces for that indented line. But other then that it appears to work > fine. Ah, the post-install line? Thanks. Although I have to say, figuring out that the project Makefile didn't actually install the manpage took me longer than anything else. [ :-) / 2 ] > There is also one niggling issue of the binaries being installed suid-root > which you might want to patch to 755 for security reasons, but it isn't > a show stopper. Hmm. If the project needn't be installed setuid-root, then maybe this should be pushed back to the author? He should change the perms used by his install target. -Chuck