From owner-freebsd-bugs@FreeBSD.ORG Wed Jan 12 16:30:29 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D05516A4CE for ; Wed, 12 Jan 2005 16:30:29 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2F5843D2F for ; Wed, 12 Jan 2005 16:30:28 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j0CGUSYO067728 for ; Wed, 12 Jan 2005 16:30:28 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j0CGUSXE067727; Wed, 12 Jan 2005 16:30:28 GMT (envelope-from gnats) Resent-Date: Wed, 12 Jan 2005 16:30:28 GMT Resent-Message-Id: <200501121630.j0CGUSXE067727@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeffrey Katcher Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E7C316A4CE for ; Wed, 12 Jan 2005 16:25:28 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 26F9943D2F for ; Wed, 12 Jan 2005 16:25:28 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j0CGPSHG004004 for ; Wed, 12 Jan 2005 16:25:28 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id j0CGPR7A003994; Wed, 12 Jan 2005 16:25:27 GMT (envelope-from nobody) Message-Id: <200501121625.j0CGPR7A003994@www.freebsd.org> Date: Wed, 12 Jan 2005 16:25:27 GMT From: Jeffrey Katcher To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: misc/76153: Significant memory leak in libfetch (fix enclosed) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jan 2005 16:30:29 -0000 >Number: 76153 >Category: misc >Synopsis: Significant memory leak in libfetch (fix enclosed) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 12 16:30:28 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Jeffrey Katcher >Release: 5.3-STABLE >Organization: >Environment: FreeBSD mammon.comcast.net 5.3-STABLE FreeBSD 5.3-STABLE #4: Fri Jan 7 14:02:42 PST 2005 katcher@mammon.comcast.net:/usr/src/sys/i386/compile/MAMMON i386 >Description: I was debugging a program with a libfetch back end under valgrind and found that libfetch was leaking about 1K/connection. My program uses a lot of individual connections so growth was noticable during a long run. >How-To-Repeat: Run any libfetch linked binary under valgrind >Fix: It's an easy fix: Conn is the connection structure, and though every conn is freed, the fact that conn has a malloced field is ignored. The fix is simply to check for the existence of this field and freeing it immediately before freeing conn itself. Patch follows: *** common.c.orig Tue Jan 11 18:44:03 2005 --- common.c Tue Jan 11 18:44:14 2005 *************** *** 605,610 **** --- 605,615 ---- if (--conn->ref > 0) return (0); ret = close(conn->sd); + + if (conn->bufsize) { + free(conn->buf); + } + free(conn); return (ret); } >Release-Note: >Audit-Trail: >Unformatted: