From owner-cvs-all Mon Oct 29 16:19:49 2001 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id E516E37B408; Mon, 29 Oct 2001 16:19:43 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id f9U0JgV01141; Mon, 29 Oct 2001 17:19:42 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost [127.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id f9U0Jb795315; Mon, 29 Oct 2001 17:19:39 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200110300019.f9U0Jb795315@harmony.village.org> To: Luigi Rizzo Subject: Re: ipfw.c -- (was: cvs commit: src/sys/netinet ip_fw.h) Cc: "Andrew R. Reiter" , Josef Karthauser , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Sun, 28 Oct 2001 21:20:26 PST." <20011028212026.A94510@iguana.aciri.org> References: <20011028212026.A94510@iguana.aciri.org> <200110290441.f9T4fSY68423@freefall.freebsd.org> Date: Mon, 29 Oct 2001 17:19:37 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20011028212026.A94510@iguana.aciri.org> Luigi Rizzo writes: : On Mon, Oct 29, 2001 at 12:11:24AM -0500, Andrew R. Reiter wrote: : > : > Sorry to reply to ipfw.c commits this way, but while there have been style : > fixes, I don't think all have been fixed. For example, in show_ipfw(), : > there is char timestr[30]; which is found in the middle of an if block. : > IIRC, isn't this a style problem as well? Also, I would imagine that it's : > just poor design to have to declare variables in the middle of a block, : > whether it be an if-block, for-block, etc.. : : actually it is _good_ design to declare variables as local as : possible, because it enables the compiler to detect more erroneous : use of the same. That's a matter of some debate. I'll just leave it at that. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message