Date: Tue, 07 Oct 2014 04:15:17 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 194210] New: [patch] graphics/gimageview: g_return_if_fail() on uninitialized variable Message-ID: <bug-194210-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194210 Bug ID: 194210 Summary: [patch] graphics/gimageview: g_return_if_fail() on uninitialized variable Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: enslay@gmail.com Created attachment 148052 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=148052&action=edit The patch that fixes the above issue. It can be dropped into the files directory in graphics/gimageview. gimageview interfaces with mplayer through some form of IPC. When processing input from mplayer in the function process_lines() found in plugins/image_view/gimv_mplayer.c, it does a few sanity checks with g_return_if_fail(). One of those checks is on the uninitialized variable 'size' which always triggers a failure when gimageview is compiled with clang (but coincidentally always worked with gcc). The attached patch initializes 'size' first so that g_return_if_fail() is no longer triggered. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194210-13>