From owner-p4-projects@FreeBSD.ORG  Tue Apr  8 15:35:13 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C67BC37B401; Tue,  8 Apr 2003 15:35:12 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4B79C37B405
	for <perforce@freebsd.org>; Tue,  8 Apr 2003 15:35:12 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E600643FA3
	for <perforce@freebsd.org>; Tue,  8 Apr 2003 15:35:11 -0700 (PDT)
	(envelope-from peter@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h38MZB0U097476
	for <perforce@freebsd.org>; Tue, 8 Apr 2003 15:35:11 -0700 (PDT)
	(envelope-from peter@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h38MZBuh097473
	for perforce@freebsd.org; Tue, 8 Apr 2003 15:35:11 -0700 (PDT)
Date: Tue, 8 Apr 2003 15:35:11 -0700 (PDT)
Message-Id: <200304082235.h38MZBuh097473@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	peter@freebsd.org using -f
From: Peter Wemm <peter@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 28567 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Apr 2003 22:35:13 -0000

http://perforce.freebsd.org/chv.cgi?CH=28567

Change 28567 by peter@peter_daintree on 2003/04/08 15:34:13

	remove damn noisy printf in setidt().
	remove tss_rsp1/rsp2 - we dont use ring 1 or 2 anywhere (neither on i386)
	add comment about missing an update of tss_rsp0 in cpu_switch()

Affected files ...

.. //depot/projects/hammer/sys/x86_64/x86_64/machdep.c#55 edit

Differences ...

==== //depot/projects/hammer/sys/x86_64/x86_64/machdep.c#55 (text+ko) ====

@@ -630,7 +630,6 @@
 	ip->gd_dpl = SEL_KPL;
 	ip->gd_p = 1;
 	ip->gd_hioffset = ((uintptr_t)func)>>16 ;
-printf("setidt: idx:%2d 0x%08x 0x%08x 0x%08x 0x%08x\n", idx, ((u_int32_t *)ip)[0], ((u_int32_t *)ip)[1], ((u_int32_t *)ip)[2], ((u_int32_t *)ip)[3]);
 }
 
 #define	IDTVEC(name)	__CONCAT(X,name)
@@ -1240,8 +1239,7 @@
 
 	/* make an initial tss so cpu can get interrupt stack on syscall! */
 	common_tss.tss.tss_rsp0 = thread0.td_kstack + KSTACK_PAGES * PAGE_SIZE - sizeof(struct pcb);
-	common_tss.tss.tss_rsp1 = common_tss.tss.tss_rsp0;
-	common_tss.tss.tss_rsp2 = common_tss.tss.tss_rsp0;
+	/* XXX we need to update tss_rsp0 in cpu_switch */
 	/* doublefault stack space, runs on ist1 */
 	common_tss.tss.tss_ist1 = (long)&dblfault_stack[sizeof(dblfault_stack)];