From owner-freebsd-ports-bugs@freebsd.org Mon Dec 21 17:09:31 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45155A4EDFB for ; Mon, 21 Dec 2015 17:09:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 35C8B18CB for ; Mon, 21 Dec 2015 17:09:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tBLH9VZh082827 for ; Mon, 21 Dec 2015 17:09:31 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 205476] x11-toolkits/wxgtk30 Provide backtrace option to configure Date: Mon, 21 Dec 2015 17:09:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: portmaster@bsdforge.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2015 17:09:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205476 --- Comment #6 from Chris Hutchinson --- (In reply to Kyle Evans from comment #2) > Hello! > > The attached patch didn't quite work out as planned- with a minor > modification to remove the '!empty' while checking PORT_OPTIONS:MBACKTRACE- > and testing against -CURRENT: > > * Enabling the option enables backtrace as expected > * Disabling the option disables backtrace as expected > * The option is defaulted to backtrace disabled as expected > > I will attach the revised version that I effectively used in these tests, > for the sake of being perfectly explicit about the modification required. Do > I need to go back to 9.3-RELEASE and 9-STABLE and prove this option is > effectively a no-op there? While I *did* examine (and approve) the patch. It looks fine. I *think* a QA run that proves it's not possible to *enable* Backtrace on a 9.x system, might be required. *But* IMHO the patch (svn diff) speaks for itself. :-) Thanks Kyle! --Chris -- You are receiving this mail because: You are the assignee for the bug.