From owner-freebsd-standards@FreeBSD.ORG  Tue Oct 22 15:47:19 2013
Return-Path: <owner-freebsd-standards@FreeBSD.ORG>
Delivered-To: freebsd-standards@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 07508104;
 Tue, 22 Oct 2013 15:47:19 +0000 (UTC)
 (envelope-from tijl@freebsd.org)
Received: from mailrelay004.isp.belgacom.be (mailrelay004.isp.belgacom.be
 [195.238.6.170])
 by mx1.freebsd.org (Postfix) with ESMTP id 6D2FD23B4;
 Tue, 22 Oct 2013 15:47:18 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Ap4GANacZlJbsUOq/2dsb2JhbABZFoJxOE6tOpEUgSQXdIIlAQEFOhwjEAsYCSUPKh4GARKICgEDBbpFj04HhCkDmAiBMIskhTSDJjo
Received: from 170.67-177-91.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([91.177.67.170])
 by relay.skynet.be with ESMTP; 22 Oct 2013 17:47:16 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id r9MFlFud079522;
 Tue, 22 Oct 2013 17:47:15 +0200 (CEST)
 (envelope-from tijl@FreeBSD.org)
Date: Tue, 22 Oct 2013 17:47:15 +0200
From: Tijl Coosemans <tijl@FreeBSD.org>
To: William Grzybowski <william88@gmail.com>, freebsd-standards@FreeBSD.org
Subject: Re: VLC 2.1.0
Message-ID: <20131022174715.59433270@kalimero.tijl.coosemans.org>
In-Reply-To: <CAHtVNLOp+Xqj+EbVsxDsLj4tjsxJkjWLm9G0ze_ND_noYGu_=Q@mail.gmail.com>
References: <CAHtVNLONK3hZTUoJoebjtdZbhwK8pA8deO1um191zF5pZowF9A@mail.gmail.com>
 <20131022152502.61214646@kalimero.tijl.coosemans.org>
 <CAHtVNLOp+Xqj+EbVsxDsLj4tjsxJkjWLm9G0ze_ND_noYGu_=Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: multimedia-list freebsd <freebsd-multimedia@freebsd.org>
X-BeenThere: freebsd-standards@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Standards compliance <freebsd-standards.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-standards>, 
 <mailto:freebsd-standards-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-standards>
List-Post: <mailto:freebsd-standards@freebsd.org>
List-Help: <mailto:freebsd-standards-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>, 
 <mailto:freebsd-standards-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2013 15:47:19 -0000

On Tue, 22 Oct 2013 12:30:38 -0200 William Grzybowski wrote:
> On Tue, Oct 22, 2013 at 11:25 AM, Tijl Coosemans <tijl@coosemans.org> wrote:
>> On Tue, 22 Oct 2013 10:55:28 -0200 William Grzybowski wrote:
>>> I am trying to update vlc to 2.1.0, its the final step to get rid of
>>> ffmpeg1 as well.
>>> I was wondering if any c++ guru out there have any clues on how to fix this:
>>>
>>> http://pastebin.ca/2469885
>>>
>>> http://people.freebsd.org/~wg/vlc2.1.0.txt
>>
>> I think the problem is that clang doesn't expect } after a label.
>> So try adding a ; or (void)0; between the label and vlc_cleanup_run().
> 
> That works, thank you!

I suspect that clang is correct to complain about this and if so we
might want to add (void)0; to the definition of pthread_cleanup_pop
in /usr/include/pthread.h.  Let's see what -standards has to say
about this.

Summarised: the idiom that VLC uses is this:

pthread_cleanup_push(...);
...
if (error) goto cleanup;
...
cleanup:
pthread_cleanup_pop(...);

Because the definition of the pthread_cleanup_pop macro starts with }
clang complains.