From owner-svn-src-head@FreeBSD.ORG  Wed Aug  1 09:33:25 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DDFA11065672;
	Wed,  1 Aug 2012 09:33:25 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 9454C8FC1E;
	Wed,  1 Aug 2012 09:33:24 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA11224;
	Wed, 01 Aug 2012 12:33:20 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1SwVIu-000Bl0-Bq; Wed, 01 Aug 2012 12:33:20 +0300
Message-ID: <5018F7DE.30200@FreeBSD.org>
Date: Wed, 01 Aug 2012 12:33:18 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:14.0) Gecko/20120728 Thunderbird/14.0
MIME-Version: 1.0
To: Ben Kaduk <minimarmot@gmail.com>, Adrian Chadd <adrian@FreeBSD.org>
References: <201208010018.q710I2Uh088989@svn.freebsd.org>
	<CAK2BMK7ZBGupTX7f74hQCfGT1s4_eyHLSBRSezZc+RU5Dvj3nQ@mail.gmail.com>
In-Reply-To: <CAK2BMK7ZBGupTX7f74hQCfGT1s4_eyHLSBRSezZc+RU5Dvj3nQ@mail.gmail.com>
X-Enigmail-Version: 1.4.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r238962 - head/sys/dev/ath/ath_rate/sample
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 09:33:26 -0000

on 01/08/2012 03:29 Ben Kaduk said the following:
> On Tue, Jul 31, 2012 at 8:18 PM, Adrian Chadd <adrian@freebsd.org> wrote:
>> --- head/sys/dev/ath/ath_rate/sample/sample.c   Tue Jul 31 23:54:15 2012        (r238961)
>> +++ head/sys/dev/ath/ath_rate/sample/sample.c   Wed Aug  1 00:18:02 2012        (r238962)
>> @@ -504,7 +504,7 @@ ath_rate_findrate(struct ath_softc *sc,
>>
>>         mrr = sc->sc_mrretry;
>>         /* XXX check HT protmode too */
>> -       if (mrr && (ic->ic_flags & IEEE80211_F_USEPROT) && !sc->sc_mrrprot)
>> +       if (mrr && (ic->ic_flags & IEEE80211_F_USEPROT && !sc->sc_mrrprot))
>>                 mrr = 0;
>>
>>         best_rix = pick_best_rate(an, rt, size_bin, !mrr);
> 
> Logical '&&' evaluates left-to-right already, so I do not see that the
> current parentheses are needed?

Yeah, adding "!= 0" after the bitwise operation would be much more logical than
shuffling the otherwise useless parentheses.


-- 
Andriy Gapon