From owner-svn-src-all@freebsd.org  Tue Feb 25 20:02:33 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1481A23DEFA;
 Tue, 25 Feb 2020 20:02:33 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 48RqbX6sWFz3Clc;
 Tue, 25 Feb 2020 20:02:32 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
Received: from [172.17.133.228] (unknown [12.202.168.51])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: rpokala)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 4B4A51C43;
 Tue, 25 Feb 2020 20:02:32 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
User-Agent: Microsoft-MacOutlook/10.22.0.200209
Date: Tue, 25 Feb 2020 12:02:29 -0800
Subject: Re: svn commit: r358317 - head/sys/kern
From: Ravi Pokala <rpokala@freebsd.org>
To: Gleb Smirnoff <glebius@FreeBSD.org>, <src-committers@freebsd.org>,
 <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Message-ID: <23A820B4-2E13-4E3E-B734-C7950298C286@panasas.com>
Thread-Topic: svn commit: r358317 - head/sys/kern
References: <202002251911.01PJBLDP091875@repo.freebsd.org>
In-Reply-To: <202002251911.01PJBLDP091875@repo.freebsd.org>
Mime-version: 1.0
Content-type: text/plain;
	charset="UTF-8"
Content-transfer-encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Feb 2020 20:02:33 -0000

-----Original Message-----
From: <owner-src-committers@freebsd.org> on behalf of Gleb Smirnoff <glebius@FreeBSD.org>
Date: 2020-02-25, Tuesday at 11:11
To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Subject: svn commit: r358317 - head/sys/kern

    Author: glebius
    Date: Tue Feb 25 19:11:20 2020
    New Revision: 358317
    URL: https://svnweb.freebsd.org/changeset/base/358317
    
    Log:
      When sendfile_swapin() sweeps through pages in search for a bogus page
      skip first and last pages.  This is a micro optimisation.

Yes, but *why* skip the first and last pages?

-Ravi

    Modified:
      head/sys/kern/kern_sendfile.c
    
    Modified: head/sys/kern/kern_sendfile.c
    ==============================================================================
    --- head/sys/kern/kern_sendfile.c	Tue Feb 25 19:04:39 2020	(r358316)
    +++ head/sys/kern/kern_sendfile.c	Tue Feb 25 19:11:20 2020	(r358317)
    @@ -462,7 +462,7 @@ sendfile_swapin(vm_object_t obj, struct sf_io *sfio, i
     		 * Restore the valid page pointers.  They are already
     		 * unbusied, but still wired.
     		 */
    -		for (j = i; j < i + count; j++)
    +		for (j = i + 1; j < i + count - 1; j++)
     			if (pa[j] == bogus_page) {
     				pa[j] = vm_page_lookup(obj,
     				    OFF_TO_IDX(vmoff(j, off)));