Date: Sat, 09 Mar 2024 13:35:20 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 450aafcba559 - main - textproc/tinyxml2: Update to 10.0.0 Message-ID: <c692c2b4680a4d3511017907a4e1ac4c@mail.infomaniak.com> In-Reply-To: <CAMHz58Q_L-t9X05rGt-x8B55f-%2BNYWxo5CRaS-iQ9HPm1Y2AEg@mail.gmail.com> References: <202402211520.41LFK8mS022399@gitrepo.freebsd.org> <9ea613e41885bc4b8cab826a1d5508da@mail.infomaniak.com> <CAMHz58Q_L-t9X05rGt-x8B55f-%2BNYWxo5CRaS-iQ9HPm1Y2AEg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2024-03-09T13:11:23.000+01:00, Po-Chuan Hsieh <sunpoet@freebsd.org> wrot= e: > On Fri, Feb 23, 2024 at 5:23=E2=80=AFAM Daniel Engberg < > daniel.engberg.lists@pyret.net> wrote: >=20 >=20 > > On 2024-02-21T16:20:08.000+01:00, Po-Chuan Hsieh <sunpoet@FreeBSD.or= g> > > wrote: > >=20 > > The branch main has been updated by sunpoet: > >=20 > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D450aafcba559f95c94c5f= 195d83b5fe4fdc3748a > >=20 > > commit 450aafcba559f95c94c5f195d83b5fe4fdc3748a > > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > AuthorDate: 2024-02-21 14:29:27 +0000 > > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > CommitDate: 2024-02-21 15:06:47 +0000 > >=20 > > textproc/tinyxml2: Update to 10.0.0 > >=20 > > - Convert to meson > > - Fix 0c022f0fc854184d95ff3303049a063a39b1f551 > > - Bump PORTREVISION for package change > > - Bump PORTREVISION of dependent ports for shlib change > > - Remove duplicate PORTREVISION from math/linbox > >=20 > > Changes: https://github.com/leethomason/tinyxml2/releases > > https://github.com/leethomason/tinyxml2/commits/ma= ster > > --- > >=20 > > Hi, > >=20 > > Please explain what you fixed as this change makes consumers utilizing > > CMake to find (lib)tinyxml2 now requiring patching when they worked fi= ne > > before your change? > >=20 > > Your patch for net/ecal is not a fix but a workaround for something th= at > > broke by this commit. > >=20 > > Here's a build log of said port and the PR related. > >=20 > > https://pdr2.bofh.network/data/132-diizzy/2024-01-01_11h58m45s/logs/ec= al-5.12.1_3.log > >=20 > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277227 > >=20 > > Best regards, > > Daniel > >=20 > =20 > Hello, >=20 > Obviously you did not handle the dependent ports which encounter shlib > change. >=20 > Enforce port A to use cmake because port B uses cmake. > This behavior is toxic. It works like a virus. >=20 > Regarding net/ecal, please explicitly point out what is the broken > in net/ecal. > If you mean something like "(ecal-5.12.1_3) > /wrkdirs/usr/ports/net/ecal/work/stage//usr/local/bin/ecal_mon_gui-5.12.1= - > required shared library libCustomQt.so not found", I see nothing related > with tinyxml2's cmake script. > Not to mention that I see the same message when tinyxml2 is built with > cmake. >=20 > The cmake problem is misleading information. >=20 > Regards, sunpoet Hi, The issue is that you broke all projects utilizing CMake's find_package rou= tine to find libtinyxml2, https://cmake.org/cmake/help/latest/command/find_= package.html explains why this breaks projects. Your commit for net/ecal is= a hack to work around this issue not fixing it, instead submit a proper PR= upstream and/or at least create a meta PR in bugzilla. If you don't want to maintain projects utilizing a certain build framework = feel tree to returns these to the pool. Best regards, Daniel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c692c2b4680a4d3511017907a4e1ac4c>