From owner-freebsd-current@FreeBSD.ORG Sun Oct 10 06:29:41 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83EC21065670 for ; Sun, 10 Oct 2010 06:29:41 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 0498E8FC17 for ; Sun, 10 Oct 2010 06:29:40 +0000 (UTC) Received: by qwe4 with SMTP id 4so907757qwe.13 for ; Sat, 09 Oct 2010 23:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=QXXFFsNT2JMqeFbsuwxQZUmACRdgtbZ5YdIupnPP17I=; b=NsKMmXCvXwBmIJfL4UKTkqKwTv3jHK1+uEq/mx4vbLF0hPcNp+QRmvEaGAetaDwKGD ZwSbhOoF9+ZfGTSGWUBgATnG143EzrH4ntmq5/eUlRq0fAqv9AYm6vpc6Tz5Z9ZALhuN e7vMjYH1ohmXzGt9gRG2kPEQyHNzLg3WuesmY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Vnqm1WzqxfB2mxLvFrFsDva422WpvP21R6fduP+zeaQETV6pt1+T63CiUjVNDQLch8 sly0RhEnrCt70pgJ1J6fVU4E5tCFhZE+VHZnnOCj/cvR58npqcOvFgkvcBrL+xu/Itav p9ofFwKKHqoSzaRuxw/jH0q5nIeVPBFCMso/o= MIME-Version: 1.0 Received: by 10.224.49.72 with SMTP id u8mr3282269qaf.9.1286692180461; Sat, 09 Oct 2010 23:29:40 -0700 (PDT) Received: by 10.229.61.29 with HTTP; Sat, 9 Oct 2010 23:29:40 -0700 (PDT) In-Reply-To: <4CB135F5.20804@DataIX.net> References: <4C76CA06.5010001@FreeBSD.org> <4CB135F5.20804@DataIX.net> Date: Sun, 10 Oct 2010 10:29:40 +0400 Message-ID: From: Sergey Kandaurov To: jhell Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Doug Barton , freebsd-rc@freebsd.org, FreeBSD Current Subject: Re: [RFC] ifconfig description support in rc.d X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Oct 2010 06:29:41 -0000 On 10 October 2010 07:41, jhell wrote: > On 08/27/2010 05:17, pluknet wrote: >> On 27 August 2010 00:09, Doug Barton wrote: >>> On 08/26/2010 12:53 PM, pluknet wrote: >>>> >>>> [cc'ing current@ as rc@ looks too quite] >>>> >>>> Hi. >>>> >>>> Since ifconfig has grown to label interfaces with >>>> ifconfig $ifname description "foobar", what about >>>> to give it more life and store i/face descriptions >>>> semi-permanently, so they will survive between reboots? >>>> >>>> This patch adds a functionality to rc.d to label >>>> interfaces at boot time. >>>> >>>> Comments are welcome. >>> >>> This seems like a good addition, thanks. Please also write a patch for >>> rc.conf.5 to describe this new functionality and I'll be happy to commi= t it. >> >> Xin Li helped me with updating rc.conf.5 (thanks!). >> It's included in attached patch. >> >>> =A0One note below. >>> >>> >>>> --- etc/network.subr =A0 =A0(revision 211280) >>>> +++ etc/network.subr =A0 =A0(working copy) >>>> @@ -1187,6 +1187,24 @@ >>>> =A0 =A0 =A0 =A0 return 0 >>>> =A0} >>>> >>>> +# ifnet_descr >>>> +# =A0 =A0 =A0Add description to all requested interfaces. >>>> +# >>>> +ifnet_descr() >>>> +{ >>>> + =A0 =A0 =A0 local _if _ifdescr >>>> + >>>> + =A0 =A0 =A0 # ifconfig_IF_descr >>>> + =A0 =A0 =A0 for _if in `ifconfig -l`; do >>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 _ifdescr=3D"`get_if_var $_if ifconfig_IF= _descr`" >>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 if [ ! -z "$_ifdescr" ]; then >>> >>> This is probably better as [ -n "$_ifdescr" ] >>> >> >> This was blindly copy&pasted after ifnet_rename(). >> So, it makes sense probably to change test expression there as well. >> [see ifnet_rename() proposed change below inline] >> This change to ifnet_rename() is not included in attached patch >> to not complicate things unnecessarily for now. >> >> Index: etc/network.subr >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- etc/network.subr =A0 =A0(revision 211280) >> +++ etc/network.subr =A0 =A0(working copy) >> @@ -1179,7 +1179,7 @@ >> =A0 =A0 =A0 =A0 # ifconfig_IF_name >> =A0 =A0 =A0 =A0 for _if in `ifconfig -l`; do >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _ifname=3D`get_if_var $_if ifconfig_IF_n= ame` >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 if [ ! -z "$_ifname" ]; then >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 if [ -n "$_ifname" ]; then >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ifconfig $_if name $_ifn= ame >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 fi >> =A0 =A0 =A0 =A0 done > > Was this ever committed ? If so does anyone have any referring svn > revisions ? > > Also if this is committed or planned to be committed is there a chance > it could be MFC'd ? > > Would be awesome if this was available on a production release without > patching ;) > Hi. I'm going to commit this after a proper review. --=20 wbr, pluknet