From owner-freebsd-current@FreeBSD.ORG Fri Aug 27 11:32:50 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id 0EB5010656A9; Fri, 27 Aug 2010 11:32:50 +0000 (UTC) Date: Fri, 27 Aug 2010 11:32:50 +0000 From: Alexander Best To: Kostik Belousov Message-ID: <20100827113250.GA51376@freebsd.org> References: <4C770BB9.2070900@delphij.net> <20100827082434.GW2396@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100827082434.GW2396@deviant.kiev.zoral.com.ua> Cc: FreeBSD Current , d@delphij.net Subject: Re: [PATCH] Use MACHINE_ARCH for boot loader X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2010 11:32:50 -0000 On Fri Aug 27 10, Kostik Belousov wrote: > On Thu, Aug 26, 2010 at 05:50:01PM -0700, Xin LI wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA256 > > > > Hi, > > > > The attached patch changes FreeBSD/x86 back to FreeBSD/i386 on i386 and > > FreeBSD/amd64 on amd64. > > > > Comments welcome! I'll commit it in by the weekend if there is no > > objection on this. > Change to FreeBSD/x86 was on purpose. And, since the same loader > can boot both i386 and amd64 kernels, I consider the current state > more logical. yeah. i think jhb wanted this to happen. the old thread for this can be found here [1]. there's also a PR with a patch submitted by myself which will make use of the keyword 'x86' throughout the whole loader(8) code. the PR number for that is 147120. would be nice if someone would commit the patch. that is of course if in fact it has really been decided that for code that's being shared between amd64 and i386 the keyword 'x86' shall be used consistently. however recently i've seen quite some commits to HEAD which make me believe that the developers (most of all jhb) want to make heavy use of the 'x86' keyword. cheers. alex > > Later, kernel reports its architecture explicitely. -- a13x