From owner-freebsd-multimedia@freebsd.org Tue Apr 13 14:24:01 2021 Return-Path: Delivered-To: freebsd-multimedia@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 59BF05E21EF for ; Tue, 13 Apr 2021 14:24:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4FKSXK1vnXz4l7l for ; Tue, 13 Apr 2021 14:24:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 416795E207E; Tue, 13 Apr 2021 14:24:01 +0000 (UTC) Delivered-To: multimedia@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4126E5E2495 for ; Tue, 13 Apr 2021 14:24:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FKSXK1Fpjz4lgd for ; Tue, 13 Apr 2021 14:24:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1E3194691 for ; Tue, 13 Apr 2021 14:24:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 13DEO15w062508 for ; Tue, 13 Apr 2021 14:24:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 13DEO1Am062507 for multimedia@FreeBSD.org; Tue, 13 Apr 2021 14:24:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: maintainer-feedback requested: [Bug 255035] multimedia/ffmpeg: fix build with lensfun option enabled Date: Tue, 13 Apr 2021 14:23:59 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: multimedia@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 14:24:01 -0000 Bugzilla Automation has asked freebsd-multimedia (Nobody) for maintainer-feedback: Bug 255035: multimedia/ffmpeg: fix build with lensfun option enabled https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255035 --- Description --- ffmpeg 4.4 switched to trunk lensfun API that is incompartible with lensfun version from our ports. So build of ffmpeg with lensfun option enabled fails with the following message: libavfilter/vf_lensfun.c:231:119: error: too few arguments to function call, expected 5, have 3 lf_modifier_enable_vignetting_correction(lensfun->modifier, lensfun->aperture, lensfun->focus_distance); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~=09=09=20=20=20=20=20=20=20 ^ /usr/local/include/lensfun/lensfun.h:3097:15: note: 'lf_modifier_enable_vignetting_correction' declared here LF_EXPORT int lf_modifier_enable_vignetting_correction ( ^ libavfilter/vf_lensfun.c:233:75: error: too few arguments to function call, expected 3, have 1 and others. The attached patch rollbacks some upstream changes to make ffmpeg buildable again. This patch is intended to be removed after lensfun upgrade.