From owner-cvs-src@FreeBSD.ORG  Mon Jun  9 05:01:28 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D1657106567D;
	Mon,  9 Jun 2008 05:01:28 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net
	[66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id A39E38FC18;
	Mon,  9 Jun 2008 05:01:28 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from [10.0.0.128] (p54.kientzle.com [66.166.149.54])
	by kientzle.com (8.12.9/8.12.9) with ESMTP id m5951Rtv049312;
	Sun, 8 Jun 2008 22:01:28 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Message-ID: <484CB927.3050101@freebsd.org>
Date: Sun, 08 Jun 2008 22:01:27 -0700
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Jeremie Le Hen <jeremie@le-hen.org>
References: <200805261721.m4QHLCF4070787@repoman.freebsd.org>
	<20080608075256.GA35560@obiwan.tataz.chchile.org>
In-Reply-To: <20080608075256.GA35560@obiwan.tataz.chchile.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit [HEAD] src/gnu/usr.bin/cpio Makefile
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jun 2008 05:01:28 -0000

This case is a little unusual: by default, I want to
install both 'cpio' programs and symlink the common name
to one of them.

How about this:
    WITH_GCPIO (default) - installs gcpio, symlinks 'cpio' unless 
WITH_BSDCPIO defined
    WITHOUT_GCPIO - does not install gcpio at all
    WITH_BSDCPIO (default) - installs bsdcpio, symlinks 'cpio'
    WITHOUT_BSDCPIO - does not install bsdcpio at all

This way, WITHOUT_BSDCPIO gives you the old behavior,
WITHOUT_GCPIO gives you the proposed new behavior;
the default gives you the transitional behavior.

Tim Kientzle


Jeremie Le Hen wrote:
> Hi Tim,
> 
> First of all, thanks for this work.  It greatly contributes to the
> cleanness of the overall source tree :-).
> 
> On Mon, May 26, 2008 at 05:21:12PM +0000, Tim Kientzle wrote:
> 
>>kientzle    2008-05-26 17:21:12 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    gnu/usr.bin/cpio     Makefile 
>>  Log:
>>  Install GNU cpio as 'gcpio', symlink to 'cpio' unless WITH_BSDCPIO is
>>  defined.
> 
> 
> There have been much work to glean all build flags over the source tree
> into a single place, namely src/share/bsd.own.mk.  See [1].  I think it
> would be better to stick to this scheme and not spread those knobs back
> in the tree.
> 
> [1] http://www.freebsd.org/cgi/cvsweb.cgi/src/share/mk/bsd.own.mk#rev1.44
> 
> Thanks.
> Regards,