Date: Tue, 09 Aug 2011 14:47:40 +0400 From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: Koop Mast <kwm@rainbow-runner.nl> Cc: FreeBSD GNOME Users <gnome@freebsd.org>, Joe Marcus Clarke <marcus@freebsd.org> Subject: Re: What `gnometarget` is bsd.gnome.mk? Message-ID: <4E41104C.1040608@yandex.ru> In-Reply-To: <1312885638.58429.8.camel@crashalot.rainbow-runner.nl> References: <4E403492.5090806@yandex.ru> <4E40D636.2000201@freebsd.org> <4E40FE8D.8080403@yandex.ru> <1312883597.58429.2.camel@crashalot.rainbow-runner.nl> <4E41085A.1080803@yandex.ru> <1312885638.58429.8.camel@crashalot.rainbow-runner.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
Koop Mast wrote on 09.08.2011 14:27: > On Tue, 2011-08-09 at 14:13 +0400, Ruslan Mahmatkhanov wrote: >> Koop Mast wrote on 09.08.2011 13:53: >>> On Tue, 2011-08-09 at 13:31 +0400, Ruslan Mahmatkhanov wrote: >>>> Joe Marcus Clarke wrote on 09.08.2011 10:39: >>>>> On 8/8/11 3:10 PM, Ruslan Mahmatkhanov wrote: >>>>>> >>>>>> This component is defined in _USE_GNOME_ALL and i see it in USE_GNOME in >>>>>> some ports. But it doesn't seemed used. What it's for? >>>>>> >>>>>> PS. I wasn't able to find anything in Porters Handbook and GNOME porting >>>>>> guide. >>>>>> >>>>> >>>>> Looks like this can be removed now. We used to have a special >>>>> CONFIGURE_TARGET for GNOME ports. If you look back through CVS history >>>>> you can see what this did. >>>>> >>>>> Joe >>>> >>>> Thank you. >>>> Here is the ports, that define USE_GNOME, and `gnometarget` is the only >>>> component, so USE_GNOME may be eliminated completely in this ports: >>>> >>>> http://pastebin.com/vpeX4r8K >>>> >>>> All the other ports that define `gnometarget` in USE_GNOME along with >>>> other components: >>>> >>>> http://pastebin.com/7j3FcEM7 >>>> >>>> Should i make pr, patches? >>>> >>> >>> I just reverted this commit since it broke 553 ports. I filed a pr >>> 159624 to track this issue. >>> >>> -Koop >> >> Ok. To be honest i didn't requested the deletion, just was curious what >> it is for :). >> > > Well you brought it to our attention, that is enough in my book :) > Anyway if you want to make a patch for this for all the ports, feel free > to attach it to the pr. If not, someone will deal with this. > > -Koop Sure i'll do this next two days. Just tell me some details about how this patch should look like. Should it be some monolithic diff against /usr/ports or it should be something to apply against single categories like /usr/ports/audio etc? The patch may lose it's actuality very fast in first case imho. -- Regards, Ruslan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E41104C.1040608>