From owner-cvs-src@FreeBSD.ORG  Wed Oct 13 06:39:09 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id ECB7316A4CE; Wed, 13 Oct 2004 06:39:09 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3B3B743D31; Wed, 13 Oct 2004 06:39:09 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id i9D6d88c035814;
	Wed, 13 Oct 2004 08:39:08 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Hidetoshi Shimokawa <simokawa@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 13 Oct 2004 05:38:42 -0000."
             <200410130538.i9D5cgfA074842@repoman.freebsd.org> 
Date: Wed, 13 Oct 2004 08:39:08 +0200
Message-ID: <35813.1097649548@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/dcons dcons.c dcons.h dcons_crom.c
	dcons_os.c dcons_os.h 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Oct 2004 06:39:10 -0000


This obliterated my tty patches for dcons, and after seeing the tangle
of #ifdefs in dcons_os.c I'm not going anywhere near it again.

My personal advice would be to have a dcons_freebsd.c and dcons_dfly.c
instead of this unholy mess.

Poul-Henning

In message <200410130538.i9D5cgfA074842@repoman.freebsd.org>, Hidetoshi Shimoka
wa writes:
>simokawa    2004-10-13 05:38:42 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/dev/dcons        dcons.c dcons.h dcons_crom.c 
>  Added files:
>    sys/dev/dcons        dcons_os.c dcons_os.h 
>  Log:
>  - Split dcons core code and OS dependent code.
>  - Implement dcons_ischar() and dcons_load_buffer().
>  - If loader passed a dcons buffer address, keep using it.
>          (We still need a patch to cheat memory management system.)
>  
>  Revision  Changes    Path
>  1.19      +71 -642   src/sys/dev/dcons/dcons.c
>  1.3       +13 -8     src/sys/dev/dcons/dcons.h
>  1.5       +9 -0      src/sys/dev/dcons/dcons_crom.c
>  1.1       +746 -0    src/sys/dev/dcons/dcons_os.c (new)
>  1.1       +44 -0     src/sys/dev/dcons/dcons_os.h (new)
>

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.