From owner-cvs-all Mon Jul 23 14:52:36 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 3D3A037B401; Mon, 23 Jul 2001 14:52:27 -0700 (PDT) (envelope-from kris@FreeBSD.org) Received: (from kris@localhost) by freefall.freebsd.org (8.11.4/8.11.4) id f6NLqRi57008; Mon, 23 Jul 2001 14:52:27 -0700 (PDT) (envelope-from kris) Message-Id: <200107232152.f6NLqRi57008@freefall.freebsd.org> From: Kris Kennaway Date: Mon, 23 Jul 2001 14:52:27 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/crypto/telnet/telnetd ext.h slc.c state.c telnetd.c termstat.c utility.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG kris 2001/07/23 14:52:27 PDT Modified files: crypto/telnet/telnetd ext.h slc.c state.c telnetd.c termstat.c utility.c Log: output_data(), output_datalen() and netflush() didn't actually guarantee to do what they are supposed to: under some circumstances output data would be truncated, or the buffer would not actually be flushed (possibly leading to overflows when the caller assumes the operation succeeded). Change the semantics so that these functions ensure they complete the operation before returning. Comment out diagnostic code enabled by '-D reports' which causes an infinite recursion and an eventual crash. Patch developed with assistance from ru and assar. Revision Changes Path 1.7 +2 -2 src/crypto/telnet/telnetd/ext.h 1.7 +1 -2 src/crypto/telnet/telnetd/slc.c 1.9 +29 -23 src/crypto/telnet/telnetd/state.c 1.17 +1 -2 src/crypto/telnet/telnetd/telnetd.c 1.8 +1 -3 src/crypto/telnet/telnetd/termstat.c 1.10 +22 -19 src/crypto/telnet/telnetd/utility.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message