From owner-freebsd-arch@freebsd.org Sun Jul 1 08:06:14 2018 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2D44FDDACF for ; Sun, 1 Jul 2018 08:06:14 +0000 (UTC) (envelope-from darius@dons.net.au) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5671084C74 for ; Sun, 1 Jul 2018 08:06:14 +0000 (UTC) (envelope-from darius@dons.net.au) Received: by mailman.ysv.freebsd.org (Postfix) id 189ACFDDACE; Sun, 1 Jul 2018 08:06:14 +0000 (UTC) Delivered-To: arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01540FDDACC for ; Sun, 1 Jul 2018 08:06:14 +0000 (UTC) (envelope-from darius@dons.net.au) Received: from ipmail01.adl2.internode.on.net (ipmail01.adl2.internode.on.net [150.101.137.133]) by mx1.freebsd.org (Postfix) with ESMTP id 0E2A584C73 for ; Sun, 1 Jul 2018 08:06:12 +0000 (UTC) (envelope-from darius@dons.net.au) Received: from ppp121-45-48-103.bras2.adl4.internode.on.net (HELO midget.dons.net.au) ([121.45.48.103]) by ipmail01.adl2.internode.on.net with ESMTP; 01 Jul 2018 17:30:58 +0930 Received: from midget.dons.net.au (localhost [127.0.0.1]) by midget.dons.net.au (8.15.1/8.14.9) with ESMTPS id w6180f1X077153 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Sun, 1 Jul 2018 17:30:54 +0930 (ACST) (envelope-from darius@dons.net.au) Received: (from mailnull@localhost) by midget.dons.net.au (8.15.1/8.14.9/Submit) id w617e9x8061123 for ; Sun, 1 Jul 2018 17:10:09 +0930 (ACST) (envelope-from darius@dons.net.au) X-Authentication-Warning: midget.dons.net.au: mailnull set sender to using -f Received: from [10.0.2.26] ([10.0.2.26]) by ns.dons.net.au (envelope-sender ) (MIMEDefang) with ESMTP id w617e3Gj060487; Sun, 01 Jul 2018 17:10:09 +0930 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: What to do about rcmdsh(3) ? From: "O'Connor, Daniel" In-Reply-To: Date: Sun, 1 Jul 2018 17:10:02 +0930 Cc: Konstantin Belousov , "freebsd-arch@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <6445FBC9-98CF-4AD7-AAB6-5091E1445A52@dons.net.au> References: <20180624121412.GY2430@kib.kiev.ua> <27EE2F1E-245C-4D97-97DE-65E9DA133AF1@dons.net.au> To: Eitan Adler X-Mailer: Apple Mail (2.3445.8.2) X-Spam-Score: -1 () No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.0 X-Scanned-By: MIMEDefang 2.75 on 10.0.2.1 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2018 08:06:15 -0000 > On 1 Jul 2018, at 13:12, Eitan Adler wrote: >> You could just leave the call, I assume it will fail with an error if = rsh isn't in the path. >=20 > It will fail unconditionally since the call looks explicitly for > /bin/rsh. Is it wrong to change the implementation to use PATH?I have > not looked closely, but are there security implications to trusting > the environment? Hmm I see.. I think it could still be OK if the hypothetical rsh port had an option = to add a symlink to /bin. -- Daniel O'Connor "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum