From owner-svn-src-head@freebsd.org Wed Sep 16 07:20:07 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 913079CE286; Wed, 16 Sep 2015 07:20:07 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wi0-x236.google.com (mail-wi0-x236.google.com [IPv6:2a00:1450:400c:c05::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 32BA81ADB; Wed, 16 Sep 2015 07:20:07 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by wicfx3 with SMTP id fx3so59101128wic.1; Wed, 16 Sep 2015 00:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=9mGMx0bA5gZiMCZ9tttQ1zuoJ4qluOnbfCj7E+pbEIA=; b=Eb5OShxtKoMHaZJ3fpxYpFQQ03Im3OfRkx8FyU58k5SnE660DFVZJB6HdrWHG0J9KO 2JZ6y71NMbbnqVdqh86pCMLUz1f5HIH9fi+VLOEmUiKh3Q6c1DCqb+q1dzDTn8ltAu1h 3BufQWE/yV4sXwz4YyNrlCncm2T8F5UYO762zmNEl8WwdYgq7MCOOAS8qdk6erjlca6a 4dBBH8SXcrRtij8fnYfgqtzfpMRDlbhVF3VmvLDJYkGdBN5U/K72irQe4sV96U7zzxtL 4w0rKhjW/VuPj1IQTovCMFl0f33Ei3AeSAXx/wmGNkAwwuw7M+WT2D4DzG/AuBIvIZeF uofg== X-Received: by 10.194.184.136 with SMTP id eu8mr20338783wjc.151.1442388005658; Wed, 16 Sep 2015 00:20:05 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id bu19sm24937918wjb.45.2015.09.16.00.20.04 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 16 Sep 2015 00:20:04 -0700 (PDT) Date: Wed, 16 Sep 2015 09:20:02 +0200 From: Mateusz Guzik To: Kevin Lo Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287852 - head/sys/dev/usb/wlan Message-ID: <20150916072002.GA32476@dft-labs.eu> References: <201509160716.t8G7GM9v047729@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201509160716.t8G7GM9v047729@repo.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2015 07:20:07 -0000 On Wed, Sep 16, 2015 at 07:16:22AM +0000, Kevin Lo wrote: > Author: kevlo > Date: Wed Sep 16 07:16:21 2015 > New Revision: 287852 > URL: https://svnweb.freebsd.org/changeset/base/287852 > > Log: > Remove checks for a NULL return value from M_WAITOK allocations. > > Modified: > head/sys/dev/usb/wlan/if_ural.c > > Modified: head/sys/dev/usb/wlan/if_ural.c > ============================================================================== > --- head/sys/dev/usb/wlan/if_ural.c Wed Sep 16 06:23:15 2015 (r287851) > +++ head/sys/dev/usb/wlan/if_ural.c Wed Sep 16 07:16:21 2015 (r287852) > @@ -566,10 +566,7 @@ ural_vap_create(struct ieee80211com *ic, > > if (!TAILQ_EMPTY(&ic->ic_vaps)) /* only one at a time */ > return NULL; > - uvp = (struct ural_vap *) malloc(sizeof(struct ural_vap), > - M_80211_VAP, M_NOWAIT | M_ZERO); > - if (uvp == NULL) > - return NULL; > + uvp = malloc(sizeof(struct ural_vap), M_80211_VAP, M_NOWAIT | M_ZERO); > vap = &uvp->vap; > /* enable s/w bmiss handling for sta mode */ > > This looks like M_NOWAIT prior to and after the commit. I have no idea if the context here allows sleeping though. -- Mateusz Guzik