From owner-svn-src-all@freebsd.org Tue Sep 1 15:52:18 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E74F33CCAFB; Tue, 1 Sep 2020 15:52:18 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bgs5Z5t2yz3VQM; Tue, 1 Sep 2020 15:52:18 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AD0A81BE94; Tue, 1 Sep 2020 15:52:18 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 081FqIDc019436; Tue, 1 Sep 2020 15:52:18 GMT (envelope-from vangyzen@FreeBSD.org) Received: (from vangyzen@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 081FqIXK019435; Tue, 1 Sep 2020 15:52:18 GMT (envelope-from vangyzen@FreeBSD.org) Message-Id: <202009011552.081FqIXK019435@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: vangyzen set sender to vangyzen@FreeBSD.org using -f From: Eric van Gyzen Date: Tue, 1 Sep 2020 15:52:18 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r365051 - head/usr.sbin/pmc X-SVN-Group: head X-SVN-Commit-Author: vangyzen X-SVN-Commit-Paths: head/usr.sbin/pmc X-SVN-Commit-Revision: 365051 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 15:52:19 -0000 Author: vangyzen Date: Tue Sep 1 15:52:18 2020 New Revision: 365051 URL: https://svnweb.freebsd.org/changeset/base/365051 Log: pmc: Fix freed internal location read Coverity detected this error. The fix duplicates the assignment on line 171. Submitted by: bret_ketchum@dell.com Reported by: Coverity MFC after: 2 weeks Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D26227 Modified: head/usr.sbin/pmc/cmd_pmc_summary.cc Modified: head/usr.sbin/pmc/cmd_pmc_summary.cc ============================================================================== --- head/usr.sbin/pmc/cmd_pmc_summary.cc Tue Sep 1 15:33:57 2020 (r365050) +++ head/usr.sbin/pmc/cmd_pmc_summary.cc Tue Sep 1 15:52:18 2020 (r365051) @@ -156,7 +156,7 @@ pmc_summary_handler(int logfd, int k, bool do_full) auto rate = ratemap[kv.first]; std::cout << "idx: " << kv.first << " name: " << name << " rate: " << rate << std::endl; while (!kv.second.empty()) { - auto &val = kv.second.back(); + auto val = kv.second.back(); kv.second.pop_back(); std::cout << val.second << ": " << val.first << std::endl; }