From owner-cvs-all@FreeBSD.ORG  Mon Jul  7 18:02:00 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0E3B537B401; Mon,  7 Jul 2003 18:01:59 -0700 (PDT)
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id AA08143F85; Mon,  7 Jul 2003 18:01:56 -0700 (PDT)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: from khavrinen.lcs.mit.edu (localhost [IPv6:::1])
	by khavrinen.lcs.mit.edu (8.12.9/8.12.9) with ESMTP id h6811seb018891
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Mon, 7 Jul 2003 21:01:55 -0400 (EDT)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.12.9/8.12.9/Submit) id h6811sTT018888;
	Mon, 7 Jul 2003 21:01:54 -0400 (EDT)
	(envelope-from wollman)
Date: Mon, 7 Jul 2003 21:01:54 -0400 (EDT)
From: Garrett Wollman <wollman@lcs.mit.edu>
Message-Id: <200307080101.h6811sTT018888@khavrinen.lcs.mit.edu>
To: wpaul@FreeBSD.ORG (Bill Paul)
In-Reply-To: <20030707234511.3B0FB37B401@hub.freebsd.org>
References: <200307071845.h67Ij1N1016542@khavrinen.lcs.mit.edu>
	<20030707234511.3B0FB37B401@hub.freebsd.org>
X-Spam-Score: -19.8 ()
	IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES
X-Scanned-By: MIMEDefang 2.33 (www . roaringpenguin . com / mimedefang)
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/net if_vlan.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jul 2003 01:02:01 -0000

<<On Mon, 7 Jul 2003 16:45:11 -0700 (PDT), wpaul@FreeBSD.ORG (Bill Paul) said:

> 1) Change vlan_input() to apply EVL_VLANOFTAG() to all incoming tags
>    (in both hardware and non-hardware tagging cases) and change the
>    vlan_ioctl() function to only accept vlan tags from 0 to 4095
>    and return EINVAL if the caller tries to set any of the other
>    bits. (Prevent user from shooting self in foot.)

I believe that this is the correct choice.  (It's probably a result of
my stupidity that the vlan driver didn't do this already.)

At some point we should do something sensible with the other bits,
too.  In some applications it might be useful to allow the user to
configure the .1p priority bits, outside of a VLAN context.  (We
should be able to at least decode frames that arrive with .1p
encapsulation but .1Q tag 0.)

-GAWollman