From owner-freebsd-current Wed Dec 15 4:16:30 1999 Delivered-To: freebsd-current@freebsd.org Received: from post.mail.nl.demon.net (post-10.mail.nl.demon.net [194.159.73.20]) by hub.freebsd.org (Postfix) with ESMTP id EC01A15097 for ; Wed, 15 Dec 1999 04:16:27 -0800 (PST) (envelope-from marcel@scc.nl) Received: from [212.238.132.94] (helo=scones.sup.scc.nl) by post.mail.nl.demon.net with esmtp (Exim 2.02 #1) id 11yDM2-0005fm-00; Wed, 15 Dec 1999 12:16:26 +0000 Received: from scc.nl (scones.sup.scc.nl [192.168.2.4]) by scones.sup.scc.nl (8.9.3/8.9.3) with ESMTP id NAA88888; Wed, 15 Dec 1999 13:16:21 +0100 (CET) (envelope-from marcel@scc.nl) Message-ID: <38578695.D41619A9@scc.nl> Date: Wed, 15 Dec 1999 13:16:21 +0100 From: Marcel Moolenaar Organization: SCC vof X-Mailer: Mozilla 4.7 [en] (X11; I; Linux 2.2.5 i386) X-Accept-Language: en MIME-Version: 1.0 To: Martin Cracauer Cc: current@FreeBSD.ORG Subject: Re: sh(1) broken caching [was: Re: Broken sh(1)?] References: <712.945183175@axl.noc.iafrica.com> <38565DEA.4487DF53@scc.nl> <19991215105728.A61202@cons.org> <38576BD2.21701740@scc.nl> <19991215122546.A24027@cons.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Martin Cracauer wrote: > > In <38576BD2.21701740@scc.nl>, Marcel Moolenaar wrote: > > It seems to me that when there's a PATH= assignment you don't want to > > add anything to the cache or alternatively, clear the cache after > > execution of the command having a PATH= assignment. > > The first solution is better, but the source messes with the hashtable > too directly in too many places. > > Appended diff does the second route. Does it fix your problems? It fixes the examples and thus my problems :-) I already created a work-around in `make buildworld' so it works on older shells without the need to build sh(1) in the bootstrap stage, because the bug only pops up when doing a parallel make (ie make -jN) because each command will be executed by the same shell instance in that case. BTW: Don't forget to remove '-g' from CFLAGS when you commit the patch :-) -- Marcel Moolenaar mailto:marcel@scc.nl SCC Internetworking & Databases http://www.scc.nl/ The FreeBSD project mailto:marcel@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message