From owner-freebsd-bugs  Wed May 29 21:50:45 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 6828737B41D
	for <freebsd-bugs@hub.freebsd.org>; Wed, 29 May 2002 21:50:02 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g4U4o2876254;
	Wed, 29 May 2002 21:50:02 -0700 (PDT)
	(envelope-from gnats)
Received: from nwww.freebsd.org (www.FreeBSD.org [216.136.204.117])
	by hub.freebsd.org (Postfix) with ESMTP id D7C9037B405
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 May 2002 21:40:41 -0700 (PDT)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by nwww.freebsd.org (8.12.2/8.12.2) with ESMTP id g4U4efhG065709
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 May 2002 21:40:41 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.2/8.12.2/Submit) id g4U4efYH065708;
	Wed, 29 May 2002 21:40:41 -0700 (PDT)
Message-Id: <200205300440.g4U4efYH065708@www.freebsd.org>
Date: Wed, 29 May 2002 21:40:41 -0700 (PDT)
From: Pete Zaitcev <zaitcev@redhat.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: misc/38727: mptable should complain about garbage arguments
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         38727
>Category:       misc
>Synopsis:       mptable should complain about garbage arguments
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 29 21:50:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Pete Zaitcev
>Release:        -current
>Organization:
Red Hat, Inc.
>Environment:
>Description:
      mptable ignores arguments with matching first letters.
>How-To-Repeat:
      
>Fix:
      

*** fbsd-current/mptable.c	Wed May 29 16:32:00 2002
--- ./mptable.c	Wed May 29 21:25:39 2002
***************
*** 327,345 ****
  	    if ( strcmp( optarg, "mesg") == 0 )
  	        dmesg = 1;
  	    else
! 	        dmesg = 0;
  	    break;
  	case 'h':
! 	    if ( strcmp( optarg, "elp") == 0 )
! 	        usage();
! 	    break;
  	case 'g':
  	    if ( strcmp( optarg, "rope") == 0 )
  	        grope = 1;
  	    break;
  	case 'v':
  	    if ( strcmp( optarg, "erbose") == 0 )
  	        verbose = 1;
  	    break;
  	default:
  	    usage();
--- 376,396 ----
  	    if ( strcmp( optarg, "mesg") == 0 )
  	        dmesg = 1;
  	    else
! 		usage();
  	    break;
  	case 'h':
! 	    usage();
  	case 'g':
  	    if ( strcmp( optarg, "rope") == 0 )
  	        grope = 1;
+ 	    else
+ 		usage();
  	    break;
  	case 'v':
  	    if ( strcmp( optarg, "erbose") == 0 )
  	        verbose = 1;
+ 	    else
+ 		usage();
  	    break;
  	default:
  	    usage();

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message