Date: Mon, 24 Aug 2015 11:01:04 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r395079 - in head/graphics: . mitsuba mitsuba/files Message-ID: <20150824090104.GB93486@ivaldir.etoilebsd.net> In-Reply-To: <20150824084807.GA93486@ivaldir.etoilebsd.net> References: <201508230856.t7N8uwal009338@repo.freebsd.org> <96D957F8044D8B647B259802@atuin.in.mat.cc> <20150824070915.GA15244@FreeBSD.org> <20150824084807.GA93486@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--xXmbgvnjoT4axfJE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Aug 24, 2015 at 10:48:07AM +0200, Baptiste Daroussin wrote:
> On Mon, Aug 24, 2015 at 07:09:15AM +0000, Alexey Dokuchaev wrote:
> > On Sun, Aug 23, 2015 at 11:43:21PM +0100, Mathieu Arnold wrote:
> > > +--On 23 ao??t 2015 08:56:58 +0000 Alexey Dokuchaev <danfe@FreeBSD.or=
g>
> > > wrote:
> > > | +# Unfortunately, the code is not GCC 4.2.1 compatible (due to bugs=
in GCC
> > > | +# itself). Try to use system compiler if it is Clang, otherwise f=
allback
> > > | +# to modern GCC (on older versions of FreeBSD).
> > > | +.if ${OSVERSION} < 900014
> > > | +USE_GCC=3D yes
> > >=20
> > > OSVERSION < 900014 will always be false. Please, don't add more chec=
ks on
> > > unsupported versions.
> >=20
> > The fact that 8.X had reached its EOL merely means we cannot promise th=
at
> > things won't break. It does not mean we should immediately pull the pl=
ug
> > and remove two lines from the Makefile, leaving 8.4 users with a broken
> > port.
> >=20
> > It's up to maintainers to decide whether it's worth supporting some old
> > FreeBSD version. Keeping around intricate patches and having to rebase
> > and test on every update is a nuisance, so those patches probably deser=
ve
> > to rest in attic now. Two lines in the Makefile are hardly a burden.
> >=20
> > I typically would try to support as many FreeBSD versions as long the
> > port stays manageable. Often it's not a problem, and is very polite to
> > our users that do not want to upgrade for some reason (e.g. me and my
> > laptop are happy with stable/8 and see no reason to update, as it will
> > likely pessimize work experience without bringing any benefits over 8.4=
).
> >=20
> > That said, OSVERSION < 900014 will not always be false. And why do you
> > want to be rude to our users and deliberately break things just because
> > we no longer promise that they will work?
> >=20
>=20
> Even in that case, this is wrong anyway as you enforce GCC while should s=
hould
> require a modern compiler via compiler.mk.
>=20
> regards,
> Bapt
Btw that would even be nicer to only use compiler.mk feature as it will give
this port a chance to work on supported freebsd version on some tiers-2
architecture which depends on gcc 4.2.1: mips, powerpc, sparc64, etc. While=
your
patch only gives a chance for it to work on unsupported version :)
Bapt
--xXmbgvnjoT4axfJE
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlXa3VAACgkQ8kTtMUmk6EwaWACgjaKd+MhMuDBs8vb078baxawI
92kAmQHCbHCKmlsW2CrkOc2qOaqWVZrl
=a15C
-----END PGP SIGNATURE-----
--xXmbgvnjoT4axfJE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150824090104.GB93486>