From owner-svn-src-head@freebsd.org Wed Dec 13 13:04:23 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67D94E9D8EB; Wed, 13 Dec 2017 13:04:23 +0000 (UTC) (envelope-from thisisadrgreenthumb@gmail.com) Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F00106FDC8; Wed, 13 Dec 2017 13:04:22 +0000 (UTC) (envelope-from thisisadrgreenthumb@gmail.com) Received: by mail-wm0-f45.google.com with SMTP id f140so4954143wmd.2; Wed, 13 Dec 2017 05:04:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+KgFBKLGFG9YrOkQo2msKqoc3bAo5GXJwq4OvHLHF8k=; b=C/r+7rpyX0oAeXEPQtkHrcq3nHhevfBRPRXknnKfmNdJoBO3dHRV/qAewOCxheYePi v30T9C2ZFV40XIuXHX2j7PGy8qRwS2t8peVnwcQ6PMaPMjMmK15y5nGSEMNLPAJwzKpT 8GCWpA4M4klq4FCkTjdb6feredPFQJw5kftstO3FhC+XKuhCd26dVkbIQAmMPZL/6IDB BqW/hGOLMKZTtywELCzZx6vmGSLh4e33v2IsjQ80R+LC8TM2ezPcyVmJH2hZ+FZAfNhr JkOYZtLWneE1NirWe7Jl4pzk24J6yJ3PIn4iIL3JW9cZJoPxEp6QTa69YiZmijHxdSY0 N8Fw== X-Gm-Message-State: AKGB3mK4CR/k6P/sWqiOWkXuPZR+R3NVN7P4j8Yx7OT1pC7TrFKajpXs wEZtBYAWOId6oQlyxS4p4+yrDcjkFXc= X-Google-Smtp-Source: ACJfBot71nqn2gg82ScS6T7zfqgOXh103JYQSId3C2IQZJCdgPMwLDO27MA4YkQN8rLUJ3eG4zYSWw== X-Received: by 10.80.204.72 with SMTP id n8mr7486322edi.64.1513169896752; Wed, 13 Dec 2017 04:58:16 -0800 (PST) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com. [74.125.82.54]) by smtp.gmail.com with ESMTPSA id c33sm1332828edd.36.2017.12.13.04.58.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Dec 2017 04:58:16 -0800 (PST) Received: by mail-wm0-f54.google.com with SMTP id t8so4827242wmc.3; Wed, 13 Dec 2017 04:58:16 -0800 (PST) X-Received: by 10.80.170.136 with SMTP id q8mr7505122edc.134.1513169896376; Wed, 13 Dec 2017 04:58:16 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.231.1 with HTTP; Wed, 13 Dec 2017 04:58:15 -0800 (PST) In-Reply-To: <87732030-061F-43FB-94D7-4DB6F6558A4B@fubar.geek.nz> References: <201712122015.vBCKFvNk047250@repo.freebsd.org> <87732030-061F-43FB-94D7-4DB6F6558A4B@fubar.geek.nz> From: Fedor Uporov Date: Wed, 13 Dec 2017 13:58:15 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r326808 - head/sys/kern To: Andrew Turner Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 13:04:23 -0000 Hi, Andrew. Thanks for report, I know about the issue. Just, need to get back home to my laptop to fix it. Need 2-4 hours. On Wed, Dec 13, 2017 at 1:46 PM, Andrew Turner wrote: > > > On 12 Dec 2017, at 20:15, Fedor Uporov wrote: > > > > Author: fsu > > Date: Tue Dec 12 20:15:57 2017 > > New Revision: 326808 > > URL: https://svnweb.freebsd.org/changeset/base/326808 > > > > Log: > > Move buffer size checks outside of the vnode locks. > > > > Reviewed by: kib, cem, pfg (mentor) > > Approved by: pfg (mentor) > > MFC after: 1 weeks > > > > Differential Revision: https://reviews.freebsd.org/D13405 > > This breaks the build when MAC is undefined, e.g. the armv7 GENERIC kernel. > > /usr/home/andrew/freebsd/repo/head-svn/sys/kern/vfs_extattr.c:201:1: > error: unused label 'done' [-Werror,-Wunused-label] > done: > ^~~~~ > /usr/home/andrew/freebsd/repo/head-svn/sys/kern/vfs_extattr.c:376:1: > error: unused label 'done' [-Werror,-Wunused-label] > done: > ^~~~~ > /usr/home/andrew/freebsd/repo/head-svn/sys/kern/vfs_extattr.c:677:1: > error: unused label 'done' [-Werror,-Wunused-label] > done: > ^~~~~ > 3 errors generated. > > Andrew > >