Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 4 Apr 2020 18:16:42 +0200
From:      Mateusz Piotrowski <0mp@FreeBSD.org>
To:        Matthias Andree <mandree@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r530685 - in head/net-mgmt/netdata: . files
Message-ID:  <9ee4098b-ca2a-f56e-977f-d43ea0ee9309@FreeBSD.org>
In-Reply-To: <202004041541.034FfRqs057049@repo.freebsd.org>
References:  <202004041541.034FfRqs057049@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 4/4/20 5:41 PM, Matthias Andree wrote:
> Author: mandree
> Date: Sat Apr  4 15:41:26 2020
> New Revision: 530685
> URL: https://svnweb.freebsd.org/changeset/ports/530685
>
> Log:
>    net-mgmt/netdata rc script overhaul, fix termination, user config
...
> Modified: head/net-mgmt/netdata/files/netdata.in
> ==============================================================================
> --- head/net-mgmt/netdata/files/netdata.in	Sat Apr  4 15:37:31 2020	(r530684)
> +++ head/net-mgmt/netdata/files/netdata.in	Sat Apr  4 15:41:26 2020	(r530685)
> @@ -13,24 +13,111 @@
...
> +# check if the rc.conf* file set and netdata_conf agree on the name to run the bundle as
> +check_user_consistency() {
> +	cfusr=$(get_user_from_conf)
> +	if [ -z "$cfusr" -o "$cfusr" = "${netdata_user}" ] ; then return 0 ; fi
> +	echo >&2 "$0: ERROR: ${netdata_conf} sets 'run as user = $cfusr', but rc.conf* sets '${netdata_user}'. Both must be consistent."
Could this use err() from rc.subr(8) instead?




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9ee4098b-ca2a-f56e-977f-d43ea0ee9309>