Date: Mon, 03 Feb 2014 13:07:39 -0700 From: Ian Lepore <ian@FreeBSD.org> To: John-Mark Gurney <jmg@funkthat.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r261424 - head/sys/dev/mmc Message-ID: <1391458059.13026.96.camel@revolution.hippie.lan> In-Reply-To: <20140203170330.GC89104@funkthat.com> References: <201402030256.s132uNjk086555@svn.freebsd.org> <20140203170330.GC89104@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2014-02-03 at 09:03 -0800, John-Mark Gurney wrote: > Ian Lepore wrote this message on Mon, Feb 03, 2014 at 02:56 +0000: > > Author: ian > > Date: Mon Feb 3 02:56:23 2014 > > New Revision: 261424 > > URL: http://svnweb.freebsd.org/changeset/base/261424 > > > > Log: > > Sort the list. > > > > Modified: > > head/sys/dev/mmc/mmc.c > > > > Modified: head/sys/dev/mmc/mmc.c > > ============================================================================== > > --- head/sys/dev/mmc/mmc.c Mon Feb 3 02:52:07 2014 (r261423) > > +++ head/sys/dev/mmc/mmc.c Mon Feb 3 02:56:23 2014 (r261424) > > @@ -1756,10 +1756,11 @@ static driver_t mmc_driver = { > > }; > > static devclass_t mmc_devclass; > > > > -DRIVER_MODULE(mmc, ti_mmchs, mmc_driver, mmc_devclass, NULL, NULL); > > DRIVER_MODULE(mmc, at91_mci, mmc_driver, mmc_devclass, NULL, NULL); > > -DRIVER_MODULE(mmc, sdhci_pci, mmc_driver, mmc_devclass, NULL, NULL); > > DRIVER_MODULE(mmc, sdhci_bcm, mmc_driver, mmc_devclass, NULL, NULL); > > DRIVER_MODULE(mmc, sdhci_fdt, mmc_driver, mmc_devclass, NULL, NULL); > > -DRIVER_MODULE(mmc, sdhci_ti, mmc_driver, mmc_devclass, NULL, NULL); > > DRIVER_MODULE(mmc, sdhci_imx, mmc_driver, mmc_devclass, NULL, NULL); > > +DRIVER_MODULE(mmc, sdhci_pci, mmc_driver, mmc_devclass, NULL, NULL); > > +DRIVER_MODULE(mmc, sdhci_ti, mmc_driver, mmc_devclass, NULL, NULL); > > +DRIVER_MODULE(mmc, ti_mmchs, mmc_driver, mmc_devclass, NULL, NULL); > > + > > Is there a reason we don't make mmc_driver/mmc_devclass global and put > all of these defines in their respective file instead of poluting an MI > file w/ MD info? > I don't think that's an option. Part of what that macro does is create metadata that says "this module contains a driver that is a child of bus <whatever>" and I think for that to work right, it has to be in the module itself, not elsewhere (at least in the .ko case; maybe it doesn't matter when it's compiled into the kernel). -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1391458059.13026.96.camel>