From owner-cvs-all Sun Jun 30 3:58:44 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4A4537B400; Sun, 30 Jun 2002 03:58:36 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA2D743E09; Sun, 30 Jun 2002 03:58:35 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g5UAuO6I074338; Sun, 30 Jun 2002 12:56:24 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Luigi Rizzo Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa clock.c src/sys/i386/include param.h src/sys/conf options.i386 In-Reply-To: Your message of "Sun, 30 Jun 2002 03:31:34 PDT." <20020630033134.A80637@iguana.icir.org> Date: Sun, 30 Jun 2002 12:56:23 +0200 Message-ID: <74337.1025434583@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020630033134.A80637@iguana.icir.org>, Luigi Rizzo writes: >But i want to emphasize that as usual this thread is about 20 lines >of conditionally compiled code which will never ever interfere with >anything else in the system. So, why check it in in the first place ? It is unused, undocumented and only you are ever going to use it and even you will have to modify the code to insert the calls to this code before you can use it. I have God knows my many pieces of code like that lying around, but since they are far to narrow of scope I don't commit them to the tree, no matter how convenient that would have been for me. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message