From owner-svn-src-head@FreeBSD.ORG Tue Oct 28 07:19:16 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 19FE61065679; Tue, 28 Oct 2008 07:19:16 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id C681C8FC23; Tue, 28 Oct 2008 07:19:15 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 7050F41C69F; Tue, 28 Oct 2008 08:00:06 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id ozyvvlXKWrfW; Tue, 28 Oct 2008 08:00:06 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id 1304841C733; Tue, 28 Oct 2008 08:00:06 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id ED79E44487F; Tue, 28 Oct 2008 06:56:23 +0000 (UTC) Date: Tue, 28 Oct 2008 06:56:23 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: John Baldwin In-Reply-To: <200810271418.41291.jhb@freebsd.org> Message-ID: <20081028065010.A2978@maildrop.int.zabbadoz.net> References: <200810271515.m9RFF86d042970@svn.freebsd.org> <200810271418.41291.jhb@freebsd.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184341 - head/usr.sbin X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2008 07:19:16 -0000 On Mon, 27 Oct 2008, John Baldwin wrote: > On Monday 27 October 2008 11:15:08 am Bjoern A. Zeeb wrote: >> Author: bz >> Date: Mon Oct 27 15:15:08 2008 >> New Revision: 184341 >> URL: http://svn.freebsd.org/changeset/base/184341 >> >> Log: >> We do not have a libkse anymore and Mk/bsd.* does not know >> about LIBKSE anymore, so s,MK_LIBKSE,MK_LIBPTHREAD,. > > Shouldn't you just remove it instead? These two options are now basically > identical. (We probably should rename libthr to libpthread at some point.) tools/build/options/WITHOUT_LIBPTHREAD still talks about kse and thus does src.conf(5). I wouldn't object to removing one of the options but according to the src.conf my bet would be LIBTHR and not LIBPTHREAD. So updating the documentation might be a good initial step as well. I have to admit that I lost track about our threading libs in different branches at one time; how many are left in head - 1 or 2? Is only libthr left and we build it as libthr and add symlinks for libpthread? >> Modified: >> head/usr.sbin/Makefile >> >> Modified: head/usr.sbin/Makefile >> > ============================================================================== >> --- head/usr.sbin/Makefile Mon Oct 27 14:49:12 2008 (r184340) >> +++ head/usr.sbin/Makefile Mon Oct 27 15:15:08 2008 (r184341) >> @@ -292,7 +292,7 @@ _moused= moused >> _vidcontrol= vidcontrol >> .endif >> >> -.if ${MK_LIBTHR} != "no" || ${MK_LIBKSE} != "no" >> +.if ${MK_LIBTHR} != "no" || ${MK_LIBPTHREAD} != "no" >> .if ${MK_PPP} != "no" >> _pppctl= pppctl >> .endif >> > > > > -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.