Date: Thu, 3 Mar 2011 19:55:23 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org Subject: svn commit: r219247 - stable/7/usr.bin/truss Message-ID: <201103031955.p23JtNCW067894@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jhb Date: Thu Mar 3 19:55:22 2011 New Revision: 219247 URL: http://svn.freebsd.org/changeset/base/219247 Log: MFC 218707: Properly check for errors from waitpid(). Modified: stable/7/usr.bin/truss/setup.c Directory Properties: stable/7/usr.bin/truss/ (props changed) Modified: stable/7/usr.bin/truss/setup.c ============================================================================== --- stable/7/usr.bin/truss/setup.c Thu Mar 3 19:55:15 2011 (r219246) +++ stable/7/usr.bin/truss/setup.c Thu Mar 3 19:55:22 2011 (r219247) @@ -83,7 +83,7 @@ setup_and_wait(char *command[]) } /* Only in the parent here */ - if (waitpid(pid, &waitval, 0) < -1) { + if (waitpid(pid, &waitval, 0) < 0) { err(1, "unexpect stop in waitpid"); return 0; } @@ -114,7 +114,7 @@ start_tracing(int pid) err(1, "can not attach to target process"); child_pid = pid; - if (waitpid(pid, &waitval, 0) < -1) + if (waitpid(pid, &waitval, 0) < 0) err(1, "Unexpect stop in waitpid"); return (0); @@ -133,7 +133,7 @@ restore_proc(int signo __unused) /* stop the child so that we can detach */ kill(child_pid, SIGSTOP); - if (waitpid(child_pid, &waitval, 0) < -1) + if (waitpid(child_pid, &waitval, 0) < 0) err(1, "Unexpected stop in waitpid"); if (ptrace(PT_DETACH, child_pid, (caddr_t)1, 0) < 0) @@ -183,7 +183,7 @@ waitevent(struct trussinfo *info) ptrace(PT_SYSCALL, info->pid, (caddr_t)1, pending_signal); pending_signal = 0; - if (waitpid(info->pid, &waitval, 0) < -1) { + if (waitpid(info->pid, &waitval, 0) < 0) { err(1, "Unexpected stop in waitpid"); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103031955.p23JtNCW067894>