From owner-freebsd-current Fri Apr 5 03:37:09 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id DAA12444 for current-outgoing; Fri, 5 Apr 1996 03:37:09 -0800 (PST) Received: from eac.iafrica.com (slipper119232.iafrica.com [196.7.119.232]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id DAA12438 for ; Fri, 5 Apr 1996 03:36:59 -0800 (PST) Received: (from rnordier@localhost) by eac.iafrica.com (8.6.12/8.6.12) id NAA00226; Fri, 5 Apr 1996 13:35:48 +0200 From: Robert Nordier Message-Id: <199604051135.NAA00226@eac.iafrica.com> Subject: Re: 2.2-960323 Panic in mount_msdos To: franky@pinewood.nl (Frank ten Wolde) Date: Fri, 5 Apr 1996 13:35:47 +0200 (SAT) Cc: current@freebsd.org In-Reply-To: <9604050935.ZM9063@pwood1.pinewood.nl> from "Frank ten Wolde" at Apr 5, 96 09:35:25 am X-Mailer: ELM [version 2.4 PL24 ME8a] Content-Type: text Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Fri, 5 Apr 1996, Frank ten Wolde wrote: > . . . . . > It would have been nice if some sanity checking would have been performed, > so that the kernel simply would abort the mount(2) system call with an > appropriate error (wrong FS type, or something similar). > > [...] > > > The DOSFS is being rewritten (not by me). > Neither by me. Don't get me wrong, I *really* like FreeBSD and my > remarks are not ment to critisize anyone. I, for sure, do *not* have the > time and resources to contribute significantly to FreeBSD and I certainly > do not make demands of any kind :-) > I simply pointed out the panic. Maybe the code maintainer of the DOSFS > can use this info to make the system even more stable. Your feedback is appreciated. I'm currently involved in re-implementing the msdosfs and agree that mounting a non-FAT fs should be trapped as an error. The same logic as used by MS-DOS 'io.sys' in recognizing, and establishing the layout of, a DOS file system is being incorporated into the new msdosfs code. -- Robert Nordier