From owner-cvs-src@FreeBSD.ORG  Sun Jul  6 17:32:17 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 077DF37B401; Sun,  6 Jul 2003 17:32:17 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6E8CF43FEC; Sun,  6 Jul 2003 17:32:16 -0700 (PDT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 51B822ED431; Sun,  6 Jul 2003 17:32:16 -0700 (PDT)
Date: Sun, 6 Jul 2003 17:32:16 -0700
From: Alfred Perlstein <bright@mu.org>
To: Garance A Drosihn <drosih@rpi.edu>
Message-ID: <20030707003216.GI72093@elvis.mu.org>
References: <200307061244.h66CiBqg079835@repoman.freebsd.org>
	<p0521064ebb2e5c8dd5e7@[128.113.24.47]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <p0521064ebb2e5c8dd5e7@[128.113.24.47]>
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Philippe Charnier <charnier@FreeBSD.org>
Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c ...
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jul 2003 00:32:17 -0000

* Garance A Drosihn <drosih@rpi.edu> [030706 16:17] wrote:
> At 5:44 AM -0700 7/6/03, Philippe Charnier wrote:
> >charnier    2003/07/06 05:44:11 PDT
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    usr.sbin/lpr/lpd     lpd.c
> >    [...etc...]
> >  Log:
> >  add FBSDID
> 
> Speaking only for lpd, I wish you would not have added FBSDID.
> I had started to add FBSDID to all the source files of
> lpr & friends, and found that it was just annoying when I
> then went to build lpr on other platforms.  So, I switched
> back to just plain 'rcsid[] ='.
> 
> It also seems odd to me that you added it to only one source
> file out of the dozens in usr.sbin/lpr.  Is there some reason
> that this one file stood out as needing FBSDID?

Isn't there a common header where you can just add:

#ifndef __FBSDID
#define __FBSDID(s)     struct __hack
#endif

?