Date: Fri, 22 May 2020 11:20:59 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 194117] libprocstat incorrectly extracts some ZFS information Message-ID: <bug-194117-227-8LbMgZwqe5@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-194117-227@https.bugs.freebsd.org/bugzilla/> References: <bug-194117-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D194117 --- Comment #1 from commit-hook@freebsd.org --- A commit references this bug: Author: avg Date: Fri May 22 11:20:25 UTC 2020 New revision: 361363 URL: https://svnweb.freebsd.org/changeset/base/361363 Log: libprocstat: fix ZFS support First of all, znode_phys_t hasn't been used for storing file attributes for a long time now. Modern ZFS versions use a System Attribute table with a flexible layout. But more importantly all the required information is available in znode_t itself. It's not easy to include zfs_znode.h in userland without breaking code because the most interesting parts of the header are kernel-only. And hardcoding field offsets is too fragile. So, I created a new compilation unit that includes zfs_znode.h using some mild kludges to get it and its dependencies to compile in userland. The compilation unit exports interesting field offsets and does not have any other code. PR: 194117 Reviewed by: markj MFC after: 2 weeks Sponsored by: Panzura Differential Revision: https://reviews.freebsd.org/D24941 Changes: head/lib/libprocstat/Makefile head/lib/libprocstat/zfs/Makefile head/lib/libprocstat/zfs.c head/lib/libprocstat/zfs_defs.c head/lib/libprocstat/zfs_defs.h --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194117-227-8LbMgZwqe5>