From owner-cvs-src@FreeBSD.ORG Sat May 31 10:55:22 2003 Return-Path: <owner-cvs-src@FreeBSD.ORG> Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7ABA237B401; Sat, 31 May 2003 10:55:22 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2E40643F3F; Sat, 31 May 2003 10:55:22 -0700 (PDT) (envelope-from wollman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h4VHtM0U011060; Sat, 31 May 2003 10:55:22 -0700 (PDT) (envelope-from wollman@repoman.freebsd.org) Received: (from wollman@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h4VHtLKx011059; Sat, 31 May 2003 10:55:21 -0700 (PDT) Message-Id: <200305311755.h4VHtLKx011059@repoman.freebsd.org> From: Garrett Wollman <wollman@FreeBSD.org> Date: Sat, 31 May 2003 10:55:21 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_output.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-src> List-Post: <mailto:cvs-src@freebsd.org> List-Help: <mailto:cvs-src-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sat, 31 May 2003 17:55:23 -0000 wollman 2003/05/31 10:55:21 PDT FreeBSD src repository Modified files: sys/netinet ip_output.c Log: Don't generate an ip_id for packets with the DF bit set; ip_id is only meaningful for fragments. Also don't bother to byte-swap the ip_id when we do generate it; it is only used at the receiver as a nonce. I tried several different permutations of this code with no measurable difference to each other or to the unmodified version, so I've settled on the one for which gcc seems to generate the best code. (If anyone cares to microoptimize this differently for an architecture where it actually matters, feel free.) Suggested by: Steve Bellovin's paper in IMW'02 Revision Changes Path 1.189 +17 -4 src/sys/netinet/ip_output.c