From owner-freebsd-amd64@FreeBSD.ORG Thu Mar 24 21:49:05 2011 Return-Path: Delivered-To: amd64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D9F37106566B for ; Thu, 24 Mar 2011 21:49:05 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 564AF8FC13 for ; Thu, 24 Mar 2011 21:49:04 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p2OLmv9H059467 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 24 Mar 2011 23:48:57 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p2OLmvGm035347; Thu, 24 Mar 2011 23:48:57 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p2OLmva2035346; Thu, 24 Mar 2011 23:48:57 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 24 Mar 2011 23:48:57 +0200 From: Kostik Belousov To: John Wehle Message-ID: <20110324214857.GE78089@deviant.kiev.zoral.com.ua> References: <201103242126.p2OLQ8HM023021@jwlab.FEITH.COM> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="N17FoJWtlLf7DYpQ" Content-Disposition: inline In-Reply-To: <201103242126.p2OLQ8HM023021@jwlab.FEITH.COM> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: amd64@freebsd.org Subject: Re: amd64/155903: FreeBSD32 emulation patch to support i386 X11 Server X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2011 21:49:05 -0000 --N17FoJWtlLf7DYpQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 24, 2011 at 05:26:08PM -0400, John Wehle wrote: > > First, please split the patch into smaller, logically self-contained > > parts. E.g. the change to handle fdrop() in one place should be committ= ed > > separately. >=20 > Will do. Okay to just submit the series of patches under amd64/155903 > or do you want them file under separate bug reports? Simply mail the patches to me, with some words attached. I will land them into the tree. >=20 > > The last commit is the most controversial, in fact. I understand the > > reason to get the user memory for calling into pciconf ioctls, but this > > is somewhat ugly. Ideally, the pci_ioctl() would be changed into wrapper > > and core code, and two wrappers produced, one for the native call path, > > other for compat32. >=20 > I don't necessarily disagree, however that's more work than I'm planning = on > at the moment. Sigh. >=20 > > BTW, would you do the shims for other pciconf ioctls, while there ? >=20 > I would have if necesary (since I was there). However at a quick glance > of pciio.h it didn't appear to me to be necessary. Also I do suspect > that the i386 X11 Server is making successfuly use of some of the other > calls. >=20 > Keep in mind that the freebsd32 layer has generic handling for those > ioctl calls that don't require anything special. I believe PCIOCREAD, > PCIOCWRITE, and friends fall into that category since it appears the > structures don't change size or alignment between i386 and amd64 > (mind you this was based just on a quick glance at the header). This is good answer, I wanted to make sure that ioctls that need special handling are handled. Thanks. --N17FoJWtlLf7DYpQ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk2LvEkACgkQC3+MBN1Mb4jHtwCgkIGQqGCBJcndvftn4UTPPyuD NcYAni3Jtwa9QQTgbtqjHtaVjVGHOyVK =vBcb -----END PGP SIGNATURE----- --N17FoJWtlLf7DYpQ--