From owner-freebsd-ports@FreeBSD.ORG Tue Feb 1 13:19:33 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4934C16A4CE for ; Tue, 1 Feb 2005 13:19:33 +0000 (GMT) Received: from aurora-borealis.phear.org (rev.phear.org [212.76.255.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 93DBE43D4C for ; Tue, 1 Feb 2005 13:19:32 +0000 (GMT) (envelope-from guzman@aurora-borealis.phear.org) Received: (from guzman@localhost) by aurora-borealis.phear.org id j11DJF16025479 for ports@freebsd.org; Tue, 1 Feb 2005 14:19:15 +0100 Date: Tue, 1 Feb 2005 14:19:15 +0100 From: guzman@zalem.net To: ports@freebsd.org Message-ID: <20050201131915.GA25469@zalem.net> References: <20050201124901.GA22120@zalem.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <20050201124901.GA22120@zalem.net> User-Agent: Mutt/1.5.4i Subject: Re: patch for mille in freebsd-games X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2005 13:19:33 -0000 --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline i'm confused and sorry... I forgot to include the patches... On Tue, Feb 01, 2005 at 01:49:01PM +0100, guzman@zalem.net wrote: > Hi, > I noticed that the game mille in the ports freebsd-games doesn't respect the man rule, when a safety card is player it's "always entitles the player to an extra turn". > the fact is that is doesn't do it. It comes from this error during compile : > cc -O -pipe -c move.c > move.c: In function `playcard': > move.c:348: warning: comparison is always false due to limited range of data type > > move.c : > Next = (Next == -1 ? FALSE : TRUE); > > where Next is a bool, so an usigned char (from curses.h). > it's easy to fix, just making Next a char and all back to normal. > I've attached patches if you ever interested in correcting this ports :) > > I've checked on the last pkg available, and in the source, the error is present. > > Sincerely, > Guzman > guzman@zalem.net --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch-mille::extern.c" --- mille/extern.c.bak Tue Feb 1 11:05:02 2005 +++ mille/extern.c Tue Feb 1 10:17:19 2005 @@ -47,10 +47,11 @@ bool Debug, /* set if debugging code on */ Finished, /* set if current hand is finished */ - Next, /* set if changing players */ On_exit, /* set if game saved on exiting */ Order, /* set if hand should be sorted */ Saved; /* set if game just saved */ + +char Next; /* set if changing players */ char *Fromfile = NULL, /* startup file for game */ Initstr[100]; /* initial string for error field */ --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch-mille::mille.h" --- mille/mille.h.bak Tue Feb 1 11:04:57 2005 +++ mille/mille.h Tue Feb 1 11:08:55 2005 @@ -212,7 +212,8 @@ * externals */ -extern bool Debug, Finished, Next, On_exit, Order, Saved; +extern bool Debug, Finished, On_exit, Order, Saved; +extern char Next; extern const char *C_fmt, **C_name; extern char *Fromfile, Initstr[]; --1yeeQ81UyVL57Vl7--