From owner-svn-src-all@FreeBSD.ORG Tue Dec 22 03:50:50 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 89B7D1065679; Tue, 22 Dec 2009 03:50:50 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 487D18FC13; Tue, 22 Dec 2009 03:50:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id nBM3nQdU040767; Mon, 21 Dec 2009 20:49:26 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 21 Dec 2009 20:49:59 -0700 (MST) Message-Id: <20091221.204959.104237699577179806.imp@bsdimp.com> To: dougb@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <4B2C127A.8060509@FreeBSD.org> References: <200912161541.53834.jhb@freebsd.org> <868wd0cyjd.fsf@ds4.des.no> <4B2C127A.8060509@FreeBSD.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@FreeBSD.org, des@des.no, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, jhb@FreeBSD.org Subject: Re: svn commit: r200606 - in head/sys: compat/freebsd32 sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2009 03:50:50 -0000 In message: <4B2C127A.8060509@FreeBSD.org> Doug Barton writes: : Dag-Erling Sm=F8rgrav wrote: : > John Baldwin writes: : >> Warner Losh writes: : >>> Log: : >>> Fix compiling FREEBSD_COMPAT[4,5,6] without FREEBSD_COMPAT7. : >>> = : >>> Note: Not sure this is the right way to do compat, but it makes= the : >>> headers consistent with the implementations. : >> Please revert. I think this has already been reverted once before= .= : > = : > Yep, that was me... we concluded back then that this is a perfectl= y : > reasonable dependency; perhaps we should simply add the appropriate= : > #ifndef / #error constructs so you can't define FREEBSD_COMPAT(n) : > without FREEBSD_COMPAT(n+1). : = : Trying to look at this from the user perspective, it's kind of silly : that if what I want is COMPAT5 I also need to add COMPAT. : = : I don't know the issues in the code so I don't know what the solution= : should be on the back end, but on the front end what needs to work is= : that I specify the compat level I want in my kernel config, then the : code does what's necessary to make that work. The trouble is that we need to do this globally, or certain definitions don't get defined. It is easier to just #error out than hack config to do the right thing I think... Warner