From owner-freebsd-multimedia@FreeBSD.ORG  Fri Aug 15 13:20:04 2008
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1E85C106566B
	for <freebsd-multimedia@hub.freebsd.org>;
	Fri, 15 Aug 2008 13:20:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id EAA918FC27
	for <freebsd-multimedia@hub.freebsd.org>;
	Fri, 15 Aug 2008 13:20:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m7FDK3GF028639
	for <freebsd-multimedia@freefall.freebsd.org>;
	Fri, 15 Aug 2008 13:20:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m7FDK3n8028638;
	Fri, 15 Aug 2008 13:20:03 GMT (envelope-from gnats)
Date: Fri, 15 Aug 2008 13:20:03 GMT
Message-Id: <200808151320.m7FDK3n8028638@freefall.freebsd.org>
To: freebsd-multimedia@FreeBSD.org
From: "Josh Carroll" <josh.carroll@gmail.com>
Cc: 
Subject: Re: ports/126045: multimedia/ffmpeg needs --enable-nonfree with
	--enable-libamr*
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Josh Carroll <josh.carroll@gmail.com>
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Aug 2008 13:20:04 -0000

The following reply was made to PR ports/126045; it has been noted by GNATS.

From: "Josh Carroll" <josh.carroll@gmail.com>
To: "Martin Matuska" <mm@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: ports/126045: multimedia/ffmpeg needs --enable-nonfree with --enable-libamr*
Date: Fri, 15 Aug 2008 09:15:11 -0400

 2008/8/15 Martin Matuska <mm@freebsd.org>:
 > I suggest a more elegant solution without any new OPTIONS:
 >
 > Index: ports/multimedia/ffmpeg/Makefile
 > ===================================================================
 > RCS file: /home/pcvs/ports/multimedia/ffmpeg/Makefile,v
 > retrieving revision 1.87
 > diff -u -r1.87 Makefile
 > --- ports/multimedia/ffmpeg/Makefile    14 Aug 2008 22:08:02 -0000      1.87
 > +++ ports/multimedia/ffmpeg/Makefile    15 Aug 2008 07:37:31 -0000
 > @@ -140,6 +140,10 @@
 >  .endif
 >
 >  ## amr
 > +.if defined(WITH_AMR_NB) || defined(WITH_AMR_WB)
 > +CONFIGURE_ARGS+=       --enable-nonfree
 > +.endif
 > +
 >  .ifdef(WITH_AMR_NB)
 >  LIB_DEPENDS+=          amrnb.3:${PORTSDIR}/audio/libamrnb
 >  CONFIGURE_ARGS+=       --enable-libamr-nb
 >
 
 I did the same thing, but because a binary compiled with amr-nb/amr-wb
 is no longer distributable, I decided to make it more visible to the
 user and make them aware of the options they were choosing.
 
 However, since the amr library options are non-default, having less
 knobs for the user is fine. I was just being overly cautious I
 suppose.
 
 Josh