From owner-freebsd-apache@FreeBSD.ORG Sat Jul 14 16:40:03 2012 Return-Path: Delivered-To: apache@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6E2E3106564A for ; Sat, 14 Jul 2012 16:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3804D8FC15 for ; Sat, 14 Jul 2012 16:40:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q6EGe3vY028658 for ; Sat, 14 Jul 2012 16:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q6EGe360028657; Sat, 14 Jul 2012 16:40:03 GMT (envelope-from gnats) Date: Sat, 14 Jul 2012 16:40:03 GMT Message-Id: <201207141640.q6EGe360028657@freefall.freebsd.org> To: apache@FreeBSD.org From: Radim Kolar Cc: Subject: Re: ports/166488: [PATCH] www/mod_auth_imap2: add dovecot patch X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Radim Kolar List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2012 16:40:03 -0000 The following reply was made to PR ports/166488; it has been noted by GNATS. From: Radim Kolar To: bug-followup@FreeBSD.org, hsn@filez.com Cc: Subject: Re: ports/166488: [PATCH] www/mod_auth_imap2: add dovecot patch Date: Sat, 14 Jul 2012 18:30:00 +0200 Here is reworked patch. Difference between this and old version is that we apply dovecot patch anyway because it follows IMAP4 protocol and will not break non dovecot system. ===> Viewing diff with more diff -ruN --exclude=CVS /usr/ports/www/mod_auth_imap2/Makefile ./Makefile --- /usr/ports/www/mod_auth_imap2/Makefile 2011-08-20 19:27:39.000000000 +0200 +++ ./Makefile 2012-07-14 18:14:19.337700139 +0200 @@ -7,7 +7,7 @@ PORTNAME= mod_auth_imap PORTVERSION= 2.2.0 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= www MASTER_SITES= http://ben.brillat.net/files/projects/mod_auth_imap2/ DISTNAME= mod_auth_imap2-${PORTVERSION} @@ -16,7 +16,9 @@ MAINTAINER= apache@FreeBSD.org COMMENT= An Apache 2 module to provide authentication via an IMAP mail server -MAKE_JOBS_SAFE= yes +LICENSE= GPLv2 + +MAKE_JOBS_SAFE= yes WRKSRC= ${WRKDIR}/${PORTNAME}2-${PORTVERSION} USE_APACHE= 20+ diff -ruN --exclude=CVS /usr/ports/www/mod_auth_imap2/files/patch-dovecot ./files/patch-dovecot --- /usr/ports/www/mod_auth_imap2/files/patch-dovecot 1970-01-01 01:00:00.000000000 +0100 +++ ./files/patch-dovecot 2012-03-29 12:40:09.000000000 +0200 @@ -0,0 +1,23 @@ +--- mod_auth_imap.c.orig 2006-05-08 01:22:43.000000000 +0200 ++++ mod_auth_imap.c 2012-03-29 12:38:30.911364281 +0200 +@@ -170,7 +170,7 @@ + tcp_gets(Sock,result,500); + + //skip lines that start with "*" +- if (strncmp(result,"* ",2 == 0)) { ++ if (strncmp(result,"* ",2) == 0) { + tcp_gets(Sock,result,500); + } + +@@ -188,6 +188,11 @@ + tcp_puts(Sock,buf); + tcp_gets(Sock,result,500); + ++ //skip lines that start with "*" ++ if (strncmp(result,"* ",2) == 0) { ++ tcp_gets(Sock,result,500); ++ } ++ + if (strncmp(result,"A002 OK",7) == 0) { + if (logflag) { + ap_log_rerror(APLOG_MARK,APLOG_WARNING|APLOG_NOERRNO,0,r,"mod_auth_imap: Verified login for user %s.", username); ===> Done